Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: neurone_loader: A Python module for loading EEG data recorded with Bittium NeurOne #1552

Open
whedon opened this issue Jul 7, 2019 · 19 comments

Comments

Projects
None yet
7 participants
@whedon
Copy link
Collaborator

commented Jul 7, 2019

Submitting author: @heilerich (Felix Heilmeyer)
Repository: https://github.com/heilerich/neurone_loader
Version: v1.1.0
Editor: @brainstorm
Reviewers: @satra

Author instructions

Thanks for submitting your paper to JOSS @heilerich. Currently, there isn't an JOSS editor assigned to your paper.

@heilerich if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Jul 7, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 7, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 7, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 7, 2019

PDF failed to compile for issue #1552 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon.rb:115:in check_fields': Paper YAML header is missing expected fields: bibliography (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon.rb:80:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon/processor.rb:36:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@labarba

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

👋 @heilerich — your paper is not compiling. Please add the required bibliography field, according to the documentation.

@heilerich

This comment has been minimized.

Copy link

commented Jul 7, 2019

my bad 🙏🏻 I added the field.
@whedon generate pdf

@labarba

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 7, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 7, 2019

@labarba

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

👋 @brainstorm — Would you be able to edit this submission?

@brainstorm

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

@satra, would you help me out reviewing this submission for JOSS? :)

@arfon

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

@satra, would you help me out reviewing this submission for JOSS? :)

Thanks @brainstorm. Just a reminder that we've moved to having a minimum of two reviewers these days incase you were planning on proceeding with just the one 😸

@brainstorm

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Argh, true, forgot about that... perhaps @chrisgorgo can be our second reviewer for JOSS? 👋

@satra

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

@brainstorm - happy to do a review.

@brainstorm

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

@whedon assign @satra as reviewer

@brainstorm

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Thanks Satra! :)

@labarba

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

@whedon assign @brainstorm as editor

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 9, 2019

OK, the editor is @brainstorm

@brainstorm

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

@rougier Would you like to assist reviewing this paper?

@rougier

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2019

I'm already late with another JOSS review but I can try do to this one by end of July if it is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.