Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: FEST-3D: Finite-volume Explicit STructured 3-Dimensional solver #1555

Closed
whedon opened this issue Jul 9, 2019 · 70 comments
Closed

[REVIEW]: FEST-3D: Finite-volume Explicit STructured 3-Dimensional solver #1555

whedon opened this issue Jul 9, 2019 · 70 comments
Assignees
Labels

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Jul 9, 2019

Submitting author: @jayten (Jatinder Pal Singh Sandhu)
Repository: https://github.com/FEST3D/FEST-3D
Version: v1.1
Editor: @labarba
Reviewers: @hariradh, @rouson
Archive: 10.5281/zenodo.3660408

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/3320d5c213241912451ed84a3b3672b7"><img src="http://joss.theoj.org/papers/3320d5c213241912451ed84a3b3672b7/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/3320d5c213241912451ed84a3b3672b7/status.svg)](http://joss.theoj.org/papers/3320d5c213241912451ed84a3b3672b7)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@hariradh, @rouson please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @labarba know.

Please try and complete your review in the next two weeks

Review checklist for @hariradh

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: v1.1
  • Authorship: Has the submitting author (@jayten) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

Review checklist for @rouson

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: v1.1
  • Authorship: Has the submitting author (@jayten) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jul 9, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @hariradh it looks like you're currently assigned to review this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jul 9, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jul 9, 2019

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Jul 9, 2019

@whedon add @rouson as reviewer

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Jul 9, 2019

OK, @rouson is now a reviewer

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Jul 9, 2019

👋 @hariradh, @rouson — This is where the action happens. You each have a review checklist above to work through. As you do, feel free to post your reviewer comments to the author in this thread. You may also open issues in the software repository as needed, and post a link here. Ask me anything!

Reviewer Guidelines on our dedicated documentation site 🚀

@hariradh

This comment has been minimized.

Copy link

@hariradh hariradh commented Jul 23, 2019

I have trouble compiling the code based on the instructions. The cmake step hangs.

$ FC=mpif90 cmake ..
-- The Fortran compiler identification is GNU 9.1.0
-- Checking whether Fortran compiler has -isysroot
-- Checking whether Fortran compiler has -isysroot - yes
-- Checking whether Fortran compiler supports OSX deployment target flag
-- Checking whether Fortran compiler supports OSX deployment target flag - yes
-- Check for working Fortran compiler: /usr/local/bin/mpif90
-- Check for working Fortran compiler: /usr/local/bin/mpif90  -- works
-- Detecting Fortran compiler ABI info
-- Detecting Fortran compiler ABI info - done
-- Checking whether /usr/local/bin/mpif90 supports Fortran 90
-- Checking whether /usr/local/bin/mpif90 supports Fortran 90 -- yes
-- CMAKE_BUILD_TYPE not given, defaulting to RELEASE

I am testing the code using:

  • Cmake 3.15
  • gcc 9.1.0
  • MPICH2 3.3.1
  • OSX 10.14.5

Cmake, gcc, and MPICH2 were installed using homebrew.

@jayten

This comment has been minimized.

Copy link

@jayten jayten commented Jul 24, 2019

The compilation problem on MacOSX has been sorted out. The following piece of code in the CMake module "SetFortranFlag.cmake" was creating a problem.

# Don't add underscores in symbols for C-compatibility
SET_COMPILE_FLAG(CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS}"
                 Fortran "-fno-underscoring")

So, the issue was corrected on Fixed the Compatibility issue of MacOSX for CMake script branch and merged with master.

The latest state of the code on master branch has been test on OSX version 10.13.4 using following:

  • CMake-3.15.0
  • Gcc-9.1.0
  • Libmpc-1.1.0
  • Mpfr-4.0.2
  • Isl-0.21
  • Gmp-6.1.2_2
  • mpich-3.3.1

Compilation was done using
$ FC=mpif90 cmake ..
and then
$ make -j 4

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Aug 14, 2019

👋 @hariradh, @rouson — how are you getting on with this review? I see the author has made some fixes, but no more comments in the last 3 weeks. Can we have a status update and an estimate of the time needed to complete the reviews?

@hariradh

This comment has been minimized.

Copy link

@hariradh hariradh commented Aug 16, 2019

@labarba @jayten

I apologize for the delay but I am having trouble testing the functionality of the code. The code fails when running the automaton.py script in the CheckInput function. I was trying to figure out the cause before sending my comments to the authors but have not been able to complete the task due to other priorities. Here are a couple of examples:

ginger:run hari$ python automaton.py
Traceback (most recent call last):
  File "automaton.py", line 347, in <module>
    CheckInput(ExpectedControl, ExpectedScheme, ExpectedFlow, ExpectedOutputControl, ExpectedResidualControl, Control, Scheme, Flow, OutputControl, ResidualControl)
  File "automaton.py", line 187, in CheckInput
    assert all(variable in ExpectedOutputControl['In'] for variable in OutputControl['In'])
AssertionError
ginger:LidDrivenCavity hari$ python automaton.py
Traceback (most recent call last):
  File "automaton.py", line 340, in <module>
    CheckInput(ExpectedControl, ExpectedScheme, ExpectedFlow, ExpectedOutputControl, ExpectedResidualControl, Control, Scheme, Flow, OutputControl, ResidualControl)
  File "automaton.py", line 183, in CheckInput
    assert len(next(os.walk(GridDir))[2]) == NumberOfBlocks
StopIteration
@jayten

This comment has been minimized.

Copy link

@jayten jayten commented Aug 16, 2019

First error:

The automaton.py in the run directory is a sample script file. This script file is not supposed to be executed as the inputs are randomly provided as an explanation for the variables. Users are supposed to copy this script and modify as according to need. In the Tutorial subfolder, different automation.py file is provided with specific inputs.

Second error:

The assertion error indicates that the number of blocks provided as input in the file (NumberOfBlocks) does not match with the number of grid files available in the GridDir. So, grid files are not created before calling setup script automaton.py. This assertion helps to avoid the breakdown of the solver after it is executed. Each block in the solver requires an individual grid file.

As described in the documentation, the grid files for Lid-driven cavity test case can be created easily by just switching to the CreatedBlock subfolder and executing make command. An important point to note here is that the grid generation requires numpy version 1.10 or above for Python2.7. Once the grids the generated, the error should not occur.

Try following steps in the LidDrivenCavity folder:

$ cd CreateBlocks/
$ make

An error might occur if "numpy" version is less than 1.10 as the function "stack" is not implemented in the older versions.

$ cd ../
$ python automaton.py

Another commonly occurring mistake is not defining the path of the AbsBinaryPath. All the other input in the automaton.py will work without changing, but AbsBinaryPath is the absolute path to the directory where FEST-3D binary is compiled on your local computer.

In the automaton.py file make sure you change following:
AbsBinaryPath="/Path/to/FEST-3D/bin/FEST3D"

More details can be found in the Documentation

@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Sep 11, 2019

@rouson thanks again for helping us review this JOSS submission. Can you please update us on your progress with this review? If you need more time please inform us as well. Thanks!

@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Sep 11, 2019

@hariradh do the comments by @jayten help you trouble shoot those errors?

@hariradh

This comment has been minimized.

Copy link

@hariradh hariradh commented Sep 14, 2019

I cannot find any unit tests or API documentation. @jayten, could you please let me know if there are any.

Other than that, there should be at least one case like the LDC which needs more clearer documentation (like that provided above) to explain how to run a test case for validation.

@jayten

This comment has been minimized.

Copy link

@jayten jayten commented Sep 16, 2019

@hariradh
I will get back on your query in a few days. We are working on it.

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Sep 29, 2019

👋 @rouson — Do you think you can complete this review within the next week or two?

@jayten

This comment has been minimized.

Copy link

@jayten jayten commented Sep 30, 2019

@hariradh

API Documentation

The FEST-3D website provides detailed documentation of different source files, modules, procedures, and main program. This documentation is generated using FORD documentation generator. You can follow the links to find information on all the subroutines and functions written in different modules.

Unit Tests

It is rather difficult to write unit tests for the FEST-3D code; therefore, we have written integrated tests instead. FEST-3D repository has been updated with a new folder: test/. Please pull the changes in the master branch on GitHub. A python script, "Test.py," provided in the test/ directory to run the integrated tests with a particular flux scheme, higher-order method, and turbulence model. Use the following command to run all tests in the test/ directory. After generating the binary, you can run the test script using the following command in the test/ folder:

$cd <FEST-3D/root/folder>/test/
$python Test.py <arg1>  <arg2>  <arg3>
  1. : Flux scheme

    • allowed options:
      • ausm
      • ldfss0
      • ausmUP
      • ausmP
      • slau
  2. : Higher-order method

    • allowed options:
      • muscl
      • ppm
      • weno
  3. : Turbulence model

    • allowed options:
      • sst
      • sst2003
      • kkl
      • sa

Examples:

  1. $python Test.py ausm muscl sst
  2. $python Test.py slau weno sa
  3. $python Test.py ausmUP ppm kkl

Please note that any flux-reconstruction scheme/higher-order method/turbulence model added by a developer can also be tested using Test.py script by suitably modifying the arguments passed to the script.

Once the tests are complete, you can check the summary in the Report.txt file. For more details about the integrated tests, please go through the TEST webpage in the FEST-3D documentation.

How to run FEST-3D

Also, as requested by @hariradh, we have updated the website with a new page on "How to run FEST-3D." This page provides a step-by-step approach on how to run the Lid-driven cavity test case.

@rouson

This comment has been minimized.

Copy link

@rouson rouson commented Oct 1, 2019

@labarba Yes, I believe I can complete my review within a week of today.

@rouson

This comment has been minimized.

Copy link

@rouson rouson commented Oct 5, 2019

@labarba @Kevin-Mattheus-Moerman I'm attempting to complete my review but finding that I'm unable to check any of the checkboxes on my checklist. Is this this submission still under review?

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Oct 5, 2019

You mean, while logged in to GitHub, you click on the box, and nothing happens? It could be a permissions issue. Though you should have been automatically added to the right team when added as a reviewer. @arfon : could you check this?

@arfon

This comment has been minimized.

Copy link
Member

@arfon arfon commented Oct 5, 2019

@rouson

This comment has been minimized.

Copy link

@rouson rouson commented Oct 5, 2019

@arfon - that did it. Thanks!

@hariradh

This comment has been minimized.

Copy link

@hariradh hariradh commented Oct 6, 2019

@whedon accept

@rouson

This comment has been minimized.

Copy link

@rouson rouson commented Feb 4, 2020

@labarba I just checked off all remaining boxes on my reviewer checklist.

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Feb 9, 2020

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 9, 2020

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Feb 9, 2020

Please merge FEST3D/FEST-3D#11 which provides small typo fixes.

Then, you need to do these final steps:

  • Please make a tagged release of your software, and list the version tag of the archived version here.
  • Archive the reviewed software in Zenodo (or a similar service)
  • Check the Zenodo deposit has the correct metadata, this includes the title (should match the paper title) and author list (make sure the list is correct and people who only made a small fix are not on it); you may also add the authors' ORCID.
  • Please list the Zenodo DOI of the archived version here.

You may find this helpful: https://guides.github.com/activities/citable-code/

@jayten

This comment has been minimized.

Copy link

@jayten jayten commented Feb 9, 2020

I have released the reviewed FEST-3D software as a new version with tag v1.1 and archived the same on Zenodo with DOI: 10.5281/zenodo.3660408 .

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Feb 9, 2020

@whedon set v1.1 as version

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 9, 2020

OK. v1.1 is the version.

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Feb 9, 2020

@whedon set 10.5281/zenodo.3660408 as archive

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 9, 2020

OK. 10.5281/zenodo.3660408 is the archive.

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Feb 10, 2020

@whedon accept

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

Attempting dry run of processing paper acceptance...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

Check final proof 👉 openjournals/joss-papers#1287

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1287, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

Reference check summary:

OK DOIs

- None

MISSING DOIs

- https://doi.org/10.2514/6.2018-3859 may be missing for title: A convergence study of solutions using two two-equation RANS turbulence models on a finite volume solver for structured grids
- https://doi.org/10.2514/6.1999-936 may be missing for title: A fast, matrix-free implicit method for compressible flows on unstructured grids
- https://doi.org/10.2514/3.12149 may be missing for title: Two-equation eddy-viscosity turbulence models for engineering applications
- https://doi.org/10.2514/6.2016-3941 may be missing for title: Verification and Validation of the k-kL Turbulence Model in FUN3D and CFL3D Codes
- https://doi.org/10.2514/6.1992-439 may be missing for title: A one-equation turbulence model for aerodynamic flows
- https://doi.org/10.1080/1061856031000104851 may be missing for title: High-order Finite Difference and Finite Volume WENO Schemes and Discontinuous Galerkin Methods for CFD
- https://doi.org/10.1016/0021-9991(84)90143-8 may be missing for title: The piecewise parabolic method (PPM) for gas-dynamical simulations
- https://doi.org/10.1243/jmes_jour_1980_022_043_02 may be missing for title: Natural Transition of Boundary Layers—The Effects of Turbulence, Pressure Gradient, and Flow History
- https://doi.org/10.1016/b978-0-444-89802-9.50059-9 may be missing for title: Further progress in the turbulence modelling of by-pass transition
- https://doi.org/10.1007/978-94-015-8666-5_6 may be missing for title: One point closure applied to transition
- https://doi.org/10.2514/6.2001-446 may be missing for title: Predictions of separated and transitional boundary layers under low-pressure turbine airfoil conditions using an intermittency transport equation
- https://doi.org/10.4208/cicp.041109.160910a may be missing for title: Performance of Low-Dissipation Euler Fluxes and Preconditioned LU-SGS at Low Speeds
- https://doi.org/10.31274/etd-180810-4424 may be missing for title: A Bypass Transition Model Based on the Intermittency Function
- https://doi.org/10.1016/j.jcp.2005.09.020 may be missing for title: A sequel to AUSM, Part II: AUSM+-up for all speeds
- https://doi.org/10.2514/1.j050905 may be missing for title: Parameter-Free Simple Low-Dissipation AUSM-Family Scheme for All Speeds
- https://doi.org/10.1016/b978-008044114-6/50053-3 may be missing for title: Transition Modelling Based on Local Variables
- https://doi.org/10.2514/6.2005-522 may be missing for title: Transition modeling for general CFD applications in aeronautics
- https://doi.org/10.1016/b978-008044544-1/50003-0 may be missing for title: Transition Modelling for General Purpose CFD Codes
- https://doi.org/10.2514/1.42362 may be missing for title: Correlation-based transition modeling for unstructured parallelized computational fluid dynamics codes
- https://doi.org/10.2514/6.2013-2531 may be missing for title: A Novel Intermittency Distribution Based Transition Model For Low-Re Number Airfoils
- https://doi.org/10.1115/1.2929110 may be missing for title: The 1991 IGTI Scholar Lecture: The Role of Laminar-Turbulent Transition in Gas Turbine Engines
- https://doi.org/10.1016/j.ijheatfluidflow.2008.09.004 may be missing for title: Correlations for modeling transitional boundary layers under influences of freestream turbulence and pressure gradient
- https://doi.org/10.2514/6.1998-867 may be missing for title: Hypersonic boundary layer transition for X-33 phase II vehicle
- https://doi.org/10.1016/0021-9991(78)90023-2 may be missing for title: A survey of several finite difference methods for systems of nonlinear hyperbolic conservation laws
- https://doi.org/10.1016/0017-9310(73)90125-7 may be missing for title: The calculation of low-Reynolds-number phenomena with a two-equation model of turbulence
- https://doi.org/10.2514/3.59994 may be missing for title: Simulation of Transition with a Two-Equation Turbulence Model
- https://doi.org/10.1115/imece2002-32740 may be missing for title: A New Model for Boundary-Layer Transition Using a Single-Point RANS Approach
- https://doi.org/10.1017/cbo9780511755385.018 may be missing for title: DNS of bypass transition
- https://doi.org/10.2514/3.1784 may be missing for title: BOUNDARY LAYER TRANSITION- FREESTREAM TURBULENCE AND PRESSURE GRADIENT EFFECTS
- https://doi.org/10.2514/6.2012-672 may be missing for title: One-Equation Transition Closure for Eddy-Viscosity Turbulence Models in CFD
- https://doi.org/10.1016/0021-9991(82)90058-4 may be missing for title: High-Re solutions for incompressible flow using the Navier-Stokes equations and a multigrid method
- https://doi.org/10.4271/975502 may be missing for title: Transition closure model for predicting transition onset
- https://doi.org/10.1063/1.168744 may be missing for title: A tensorial approach to computational continuum mechanics using object-oriented techniques
- https://doi.org/10.2514/1.j053813 may be missing for title: SU2: An open-source suite for multiphysics simulation and design

INVALID DOIs

- None
@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Feb 10, 2020

👋 @jayten — Please go over your reference list and add DOIs where available. Use the doi field and put just the identifier, not the full URL. Also, check the capitalization of journal titles, and acronyms like AIAA (appears as Aiaa in places). If you need to protect caps, use{}.

@jayten

This comment has been minimized.

Copy link

@jayten jayten commented Feb 10, 2020

I have added doi field for each bib entry and also removed the unused entries from the paper.bib file. Additionally, I included {} in the booktitle field to make sure that AIAA acroynms appears correctly.

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Feb 10, 2020

@whedon accept

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

Attempting dry run of processing paper acceptance...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

Reference check summary:

OK DOIs

- 10.2514/6.2018-3859 is OK
- 10.2514/3.12149 is OK
- 10.2514/6.2016-3941 is OK
- 10.2514/6.1992-439 is OK
- 10.1080/1061856031000104851 is OK
- 10.1016/0021-9991(84)90143-8 is OK
- 10.1016/0021-9991(79)90145-1 is OK
- 10.1007/s10494-015-9622-4 is OK
- 10.1177/0954406217743537 is OK
- 10.1063/1.168744 is OK
- 10.2514/1.J053813 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

Check final proof 👉 openjournals/joss-papers#1288

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1288, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Feb 10, 2020

@whedon accept deposit=true

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

Doing it live! Attempting automated processing of paper acceptance...
@whedon whedon added the accepted label Feb 10, 2020
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 openjournals/joss-papers#1289
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01555
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

@labarba

This comment has been minimized.

Copy link
Member

@labarba labarba commented Feb 10, 2020

Congratulations, @jayten, your JOSS article is published! 🚀

Huge thanks to our reviewers: @hariradh, @rouson — we truly appreciate your contribution to this adventure in scholarly publishing 🙏

@labarba labarba closed this Feb 10, 2020
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 10, 2020

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.01555/status.svg)](https://doi.org/10.21105/joss.01555)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01555">
  <img src="https://joss.theoj.org/papers/10.21105/joss.01555/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.01555/status.svg
   :target: https://doi.org/10.21105/joss.01555

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@jayten

This comment has been minimized.

Copy link

@jayten jayten commented Feb 10, 2020

On behalf of the FEST-3D team, I would like to thank @hariradh and @rouson for their time and effort to help us improve our work.

Also, a big thanks to @whedon and @labarba, for providing such a unique platform for publishing our work.

@rouson

This comment has been minimized.

Copy link

@rouson rouson commented Feb 13, 2020

Congrats, @jayten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.