Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: drms: A Python package for accessing HMI and AIA data #1559

Open
whedon opened this issue Jul 11, 2019 · 16 comments

Comments

Projects
None yet
5 participants
@whedon
Copy link
Collaborator

commented Jul 11, 2019

Submitting author: @kbg (Kolja Glogowski)
Repository: https://github.com/sunpy/drms
Version: v0.5.6
Editor: @xuanxu
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @kbg. Currently, there isn't an JOSS editor assigned to your paper.

@kbg if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Jul 11, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

PDF failed to compile for issue #1559 with the following error:

Can't find any papers to compile :-(

@arfon

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

👋 @xuanxu - would you be willing to edit this submission for JOSS?

@whedon whedon added the Python label Jul 11, 2019

@arfon

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@whedon generate pdf from branch joss-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

PDF failed to compile for issue #1559 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon/orcid_validator.rb:12:in initialize': undefined method strip' for nil:NilClass (NoMethodError)
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon.rb:123:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon.rb:123:in block in check_orcids'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon.rb:121:in each' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon.rb:121:in check_orcids'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon.rb:81:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon/processor.rb:36:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/lib/whedon/processor.rb:36:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/bin/whedon:55:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-85c572552d68/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

@arfon

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@kbg this PR should fix your paper: sunpy/drms#29

@arfon

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@whedon generate pdf from branch joss-paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

@kbg

This comment has been minimized.

Copy link

commented Jul 11, 2019

@arfon Thanks. I forgot to add the ORCID for one of the authors. I also spotted a missing hyphen in one of the affiliations. Both should be fixed now.

@xuanxu

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@whedon assign @xuanxu as editor

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

OK, the editor is @xuanxu

@xuanxu

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

👋 @mgckind and @astrom-tom: Would you be willing to be the reviews of this paper? I think your expertise in Python and astrophysics data management makes both of you a great fit for this submission.

@mgckind

This comment has been minimized.

Copy link

commented Jul 12, 2019

@xuanxu, thanks for the ping, I'm still on vacation I might be able to give you a realistic answer early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.