Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: Spruceup: fast and flexible identification, visualization, and removal of outliers from large multiple sequence alignments #1635

Closed
whedon opened this issue Aug 9, 2019 · 41 comments

Comments

@whedon
Copy link
Collaborator

commented Aug 9, 2019

Submitting author: @marekborowiec (Marek Borowiec)
Repository: https://github.com/marekborowiec/spruceup
Version: v2019.2.3
Editor: @csoneson
Reviewer: @iimog, @gavinmdouglas
Archive: 10.5281/zenodo.3476875

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/841347d12b4da595f6751339fac8f29c"><img src="https://joss.theoj.org/papers/841347d12b4da595f6751339fac8f29c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/841347d12b4da595f6751339fac8f29c/status.svg)](https://joss.theoj.org/papers/841347d12b4da595f6751339fac8f29c)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@iimog & @gavinmdouglas, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @csoneson know.

Please try and complete your review in the next two weeks

Review checklist for @iimog

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: v2019.2.3
  • Authorship: Has the submitting author (@marekborowiec) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

Review checklist for @gavinmdouglas

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: v2019.2.3
  • Authorship: Has the submitting author (@marekborowiec) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 9, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @iimog, @gavinmdouglas it looks like you're currently assigned to review this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 9, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 9, 2019

@csoneson

This comment has been minimized.

Copy link

commented Aug 9, 2019

@iimog, @gavinmdouglas - please perform your review in this issue (see instructions in the first comment above). If you have any questions, don't hesitate to ping me.

@marekborowiec - please have a look at the review criteria in the checklists above and check that your repository contains all the required items. Otherwise, you can add them already now to simplify the review process!

@csoneson

This comment has been minimized.

Copy link

commented Sep 3, 2019

Hi all - I just wanted to check in on this submission and the progress of the review process. @marekborowiec - there seems to be a couple of issues open in your repository, do you think you will be able to address them? Don't hesitate to ping me if anything is unclear!

@marekborowiec

This comment has been minimized.

Copy link

commented Sep 3, 2019

Hello all,

Thank you for checking in, @csoneson; I'm working on it!
@iimog and @gavinmdouglas: thank you both for constructive reviews! Your suggestions will help me improve the tool. Please bear with me as I'm slowly getting through them; I might be asking some clarification questions along the way!

@csoneson

This comment has been minimized.

Copy link

commented Sep 23, 2019

Just checking in again - @marekborowiec, could you give us an update on the progress with the revision?

@marekborowiec

This comment has been minimized.

Copy link

commented Sep 26, 2019

Thanks for checking in @csoneson. Still working on it. I'm almost done with the long laundry list of problems in Issue #5. My schedule becomes better at the end of this week and I hope I'll be able to address all the remaining issues next week.

@gavinmdouglas

This comment has been minimized.

Copy link

commented Oct 4, 2019

All of my points have been addressed in marekborowiec/spruceup#5 and I have nothing else to be addressed.

@iimog

This comment has been minimized.

Copy link

commented Oct 5, 2019

Same applies to me. All my points have been addressed to my satisfaction. Nothing to add.

@csoneson

This comment has been minimized.

Copy link

commented Oct 5, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 5, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 5, 2019

@csoneson

This comment has been minimized.

Copy link

commented Oct 5, 2019

@whedon check references

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 5, 2019

Attempting to check references...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 5, 2019


OK DOIs

- 10.1016/j.ympev.2016.05.030 is OK
- 10.1186/s12864-015-2146-4 is OK
- 10.1093/sysbio/syw101 is OK
- 10.1093/bioinformatics/btp348 is OK
- 10.1186/1471-2148-10-210 is OK
- 10.1186/s12862-019-1350-2 is OK
- 10.1186/1748-7188-3-7 is OK
- 10.1016/j.ympev.2015.10.027 is OK
- 10.1093/sysbio/sys004 is OK
- 10.1186/1742-9994-7-10 is OK
- 10.1186/s12864-018-4620-2 is OK
- 10.1080/10635150500541730 is OK
- 10.1093/nar/gkq443 is OK
- 10.5852/ejt.2017.283 is OK
- 10.1038/s41559-017-0126 is OK
- 10.1080/14772000.2017.1401016 is OK
- 10.1080/10635150701472164 is OK
- 10.1093/sysbio/syy043 is OK
- 10.1093/bioinformatics/bty448 is OK
- 10.1371/journal.pone.0030288 is OK
- 10.1093/molbev/msu245 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@csoneson

This comment has been minimized.

Copy link

commented Oct 5, 2019

@iimog, @gavinmdouglas - thanks a lot for your thorough reviews!

@marekborowiec - I have sent a PR with a couple of small fixes to a few bib items. I'll get back to you shortly to finalize the acceptance.

@marekborowiec

This comment has been minimized.

Copy link

commented Oct 7, 2019

Thank you, @csoneson!

@csoneson

This comment has been minimized.

Copy link

commented Oct 7, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 7, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 7, 2019

@csoneson

This comment has been minimized.

Copy link

commented Oct 7, 2019

@marekborowiec - paper looks good. Here are the next steps:

  • Check that the software version is consistently reported
  • Create a tagged release of the current version of the software and report the version tag here
  • Archive the software in Zenodo. Make sure that the title and authors of the archive are the same as those of the paper (you can also add ORCID)
  • Report back the doi of the Zenodo archive here
@marekborowiec

This comment has been minimized.

Copy link

commented Oct 7, 2019

The pdf looks great! One minor remark: the current release is 2019.2.2, not 2019.1.1 as indicated at the top of this page.

@csoneson

This comment has been minimized.

Copy link

commented Oct 7, 2019

That's fine - we'll set the release version when the Zenodo archive is done. That will be the final version reported with the publication.

@marekborowiec

This comment has been minimized.

Copy link

commented Oct 8, 2019

Thanks, @csoneson

  • Check that the software version is consistently reported
  • Create a tagged release of the current version of the software and report the version tag here

marekborowiec/spruceup@2dbe92f

  • Archive the software in Zenodo. Make sure that the title and authors of the archive are the same as those of the paper (you can also add ORCID)
  • Report back the doi of the Zenodo archive here

https://doi.org/10.5281/zenodo.3476875

@csoneson

This comment has been minimized.

Copy link

commented Oct 8, 2019

@whedon set v2019.2.3 as version

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

OK. v2019.2.3 is the version.

@csoneson

This comment has been minimized.

Copy link

commented Oct 8, 2019

@whedon set 10.5281/zenodo.3476875 as archive

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

OK. 10.5281/zenodo.3476875 is the archive.

@csoneson

This comment has been minimized.

Copy link

commented Oct 8, 2019

@whedon accept

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

Attempting dry run of processing paper acceptance...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019


OK DOIs

- 10.1016/j.ympev.2016.05.030 is OK
- 10.1186/s12864-015-2146-4 is OK
- 10.1093/sysbio/syw101 is OK
- 10.1093/bioinformatics/btp348 is OK
- 10.1186/1471-2148-10-210 is OK
- 10.1186/s12862-019-1350-2 is OK
- 10.1186/1748-7188-3-7 is OK
- 10.1016/j.ympev.2015.10.027 is OK
- 10.1093/sysbio/sys004 is OK
- 10.1186/1742-9994-7-10 is OK
- 10.1186/s12864-018-4620-2 is OK
- 10.1080/10635150500541730 is OK
- 10.1093/nar/gkq443 is OK
- 10.5852/ejt.2017.283 is OK
- 10.1038/s41559-017-0126 is OK
- 10.1080/14772000.2017.1401016 is OK
- 10.1080/10635150701472164 is OK
- 10.1093/sysbio/syy043 is OK
- 10.1093/bioinformatics/bty448 is OK
- 10.1371/journal.pone.0030288 is OK
- 10.1093/molbev/msu245 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

Check final proof 👉 openjournals/joss-papers#1009

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1009, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
@csoneson

This comment has been minimized.

Copy link

commented Oct 8, 2019

@openjournals/joss-eics - we're ready for you to take over!

@labarba

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

@whedon accept deposit=true

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

Doing it live! Attempting automated processing of paper acceptance...
@whedon whedon added the accepted label Oct 8, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 openjournals/joss-papers#1013
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01635
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

@labarba

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Congratulations, @marekborowiec, your JOSS paper is now published! 🚀

Big thanks to our editor: @csoneson, and the reviewers: @iimog, @gavinmdouglas — your contribution to JOSS is greatly appreciated 🙏

@marekborowiec

This comment has been minimized.

Copy link

commented Oct 8, 2019

@labarba labarba closed this Oct 9, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 9, 2019

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.01635/status.svg)](https://doi.org/10.21105/joss.01635)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01635">
  <img src="https://joss.theoj.org/papers/10.21105/joss.01635/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.01635/status.svg
   :target: https://doi.org/10.21105/joss.01635

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.