Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: tabula: An R Package for Analysis, Seriation and Visualization of Archaeological Count Data #1821

Closed
whedon opened this issue Oct 19, 2019 · 72 comments
Assignees
Labels

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Oct 19, 2019

Submitting author: @nfrerebeau (Nicolas Frerebeau)
Repository: https://github.com/nfrerebeau/tabula
Version: v1.4.0
Editor: @oliviaguest
Reviewer: @izaromanowska, @soodoku
Archive: 10.5281/zenodo.3552904

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d4f9ee7bc85e4e6cb66bb12406570b73"><img src="https://joss.theoj.org/papers/d4f9ee7bc85e4e6cb66bb12406570b73/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d4f9ee7bc85e4e6cb66bb12406570b73/status.svg)](https://joss.theoj.org/papers/d4f9ee7bc85e4e6cb66bb12406570b73)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@izaromanowska & @soodoku, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @oliviaguest know.

Please try and complete your review in the next two weeks

Review checklist for @izaromanowska

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@nfrerebeau) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @soodoku

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@nfrerebeau) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 19, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @izaromanowska, @soodoku it looks like you're currently assigned to review this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 19, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Oct 19, 2019

@oliviaguest

This comment has been minimized.

Copy link
Member

@oliviaguest oliviaguest commented Oct 19, 2019

Hey @izaromanowska and @soodoku!

This is where the reviewing proper happens. You need to go through the checklist and feel free to post questions here and open review issues in the submission repository: https://github.com/nfrerebeau/tabula (If you do please link to them here to help keep track.)

@izaromanowska

This comment has been minimized.

Copy link

@izaromanowska izaromanowska commented Oct 31, 2019

Hi @oliviaguest, I've done the review following the checklist. All works well as far as I can tell and is impressively well described. Do you need a written review as well?
One tiny suggestion is to mention in the readme that khroma needs to be installed and loaded. Probably unnecessary for most users but it's the only dependency that kicked off when checking examples on a freshly installed RStudio.

nfrerebeau added a commit to nfrerebeau/tabula that referenced this issue Oct 31, 2019
@oliviaguest

This comment has been minimized.

Copy link
Member

@oliviaguest oliviaguest commented Nov 1, 2019

@izaromanowska thank you!

All works well as far as I can tell and is impressively well described. Do you need a written review as well?

It's up to you how much further feedback or ideas you want to share with the authors.

@oliviaguest

This comment has been minimized.

Copy link
Member

@oliviaguest oliviaguest commented Nov 4, 2019

@soodoku any chance you can get this done within the next week?

@soodoku

This comment has been minimized.

Copy link

@soodoku soodoku commented Nov 4, 2019

@oliviaguest --- plausibly. will work on the weekend on this, getting started sooner.

@oliviaguest

This comment has been minimized.

Copy link
Member

@oliviaguest oliviaguest commented Nov 11, 2019

@soodoku thanks!
@nfrerebeau have you made any edits with respect to what @izaromanowska has given you feedback on?

@nfrerebeau

This comment has been minimized.

Copy link

@nfrerebeau nfrerebeau commented Nov 11, 2019

As suggested by @izaromanowska, I have modified the README so that khroma is installed and loaded.

@oliviaguest

This comment has been minimized.

Copy link
Member

@oliviaguest oliviaguest commented Nov 15, 2019

@soodoku any luck finding time? I can set up an automated reminder for you if you want/think it can be helpful? 😄

@soodoku

This comment has been minimized.

Copy link

@soodoku soodoku commented Nov 15, 2019

not yet, @oliviaguest but soon. on my agenda.

@soodoku

This comment has been minimized.

Copy link

@soodoku soodoku commented Nov 16, 2019

I have created a few issues. None are blockers but would love to get @nfrerebeau's eyes on them.

https://github.com/nfrerebeau/tabula/issues

once that's done, we can move fast.

@oliviaguest

This comment has been minimized.

Copy link
Member

@oliviaguest oliviaguest commented Nov 18, 2019

@soodoku thank you!

@nfrerebeau

This comment has been minimized.

Copy link

@nfrerebeau nfrerebeau commented Nov 19, 2019

@soodoku thank you for all these constructive remarks. I will look in detail before the weekend and make the necessary changes.

@soodoku

This comment has been minimized.

Copy link

@soodoku soodoku commented Nov 20, 2019

good to go from my end. thanks @nfrerebeau for bearing with me.

@oliviaguest

This comment has been minimized.

Copy link
Member

@oliviaguest oliviaguest commented Nov 25, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 25, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 25, 2019

@oliviaguest

This comment has been minimized.

Copy link
Member

@oliviaguest oliviaguest commented Nov 25, 2019

@nfrerebeau please check the article and let me know if everything looks good to you. 😄

nfrerebeau added a commit to nfrerebeau/tabula that referenced this issue Nov 25, 2019
@nfrerebeau

This comment has been minimized.

Copy link

@nfrerebeau nfrerebeau commented Nov 25, 2019

@oliviaguest I fixed a small typo, everything else is OK!

@oliviaguest

This comment has been minimized.

Copy link
Member

@oliviaguest oliviaguest commented Nov 25, 2019

@whedon accept

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 25, 2019

No archive DOI set. Exiting...

@oliviaguest

This comment has been minimized.

Copy link
Member

@oliviaguest oliviaguest commented Dec 1, 2019

@Kevin-Mattheus-Moerman ah, thanks! I tagged Lorena because she is helping me out. Sorry for the extra pressure (none intended) — was more worried I did something wrong. Thanks again!

@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Dec 1, 2019

@whedon set v1.4.0 as version

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 1, 2019

OK. v1.4.0 is the version.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Dec 1, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 1, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 1, 2019

@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Dec 1, 2019

@nfrerebeau below are some suggested changes for your paper:

  • The paper contains 1 instance of ...allowed the... and 3 instances of ...allow the.... Please consider adding for, i.e. so it reads ... allowed for the..., and ... allow for the... (or change to use enabled, enables).
  • In this sentence the referencing can be improved It may use a priori information, e.g., absolute dates or stratigraphical constraints: Poblome & Groenen (2003), and allows the analysis of chronological patterns in a socio-economic or cultural perspective, e.g., Bellanger & Husi (2012), Lipo, Madsen, & Dunnell (2015).,
    Consider reformatting to:
    It may use a priori information, e.g., absolute dates or stratigraphical constraints (Poblome & Groenen 2003), and allows for the analysis of chronological patterns in a socio-economic or cultural perspective (e.g., (Bellanger & Husi 2012), (Lipo, Madsen, & Dunnell 2015)).
  • In ...count data, e.g., artifacts, faunal remains, etc. consider rephrasing to ...count data, such as artifacts and faunal remains, which reads better and avoids the use of etc. at the end of a sentence.
  • In ...of diversity indices and implements seriation/ordination methods, but..., since packages is plural this should have implement not implements.
  • Should the [a] be added here? ...Estimated dates can then be displayed as [a] tempo or activity plot...
  • If I understand the following correctly: ...abundance plots, heatmaps, Ford (1962), and Bertin (1977) diagrams. , perhaps it should read this instead: ...abundance plots, heatmaps, and Ford (1962) and Bertin (1977) diagrams.
  • In All the contributors have made..., I suggest: The following contributors have made...
@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Dec 1, 2019

@nfrerebeau

  • Please amend the meta data for the Zenodo archived version such that the title and the author set matches that of the paper.
  • The archived version lists version v1.4.0 (which I've updated here already), can you confirm this is correct (and that this is the version of the reviewed and archived software)?
@nfrerebeau

This comment has been minimized.

Copy link

@nfrerebeau nfrerebeau commented Dec 2, 2019

@Kevin-Mattheus-Moerman I made the changes you suggested. Thank you for taking the time to improve my text.

I modified the title of the Zenodo archive. The author set in the meta data already matches that of the paper, or am I missing something?

I confirm that v1.4.0 is the version of the reviewed and archived software.

@oliviaguest

This comment has been minimized.

Copy link
Member

@oliviaguest oliviaguest commented Dec 2, 2019

@nfrerebeau if you can tick them off, that will help — thanks! 😄

@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Dec 2, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Dec 2, 2019

@nfrerebeau nearly there. I left one box unchecked ☝️ . You introduced [a] but I meant for you to introduce a, so please remove the square brackets. You can call @whedon generate pdf here when you are done. Thanks.

@nfrerebeau

This comment has been minimized.

Copy link

@nfrerebeau nfrerebeau commented Dec 2, 2019

@Kevin-Mattheus-Moerman I was a little too fast on this one 😅

@nfrerebeau

This comment has been minimized.

Copy link

@nfrerebeau nfrerebeau commented Dec 2, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Dec 2, 2019

@whedon accept

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

Attempting dry run of processing paper acceptance...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019


OK DOIs

- 10.1016/j.jas.2011.06.031 is OK
- 10.18637/jss.v022.i04 is OK
- 10.2307/278341 is OK
- 10.1016/j.jas.2016.05.006 is OK
- 10.1007/3-540-28084-7_34 is OK
- 10.1371/journal.pone.0124942 is OK
- 10.2307/2843012 is OK

MISSING DOIs

- https://doi.org/10.2307/501681 may be missing for title: A Quantitative Method for Deriving Cultural Chronology

INVALID DOIs

- None
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

Check final proof 👉 openjournals/joss-papers#1141

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1141, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Dec 2, 2019

@whedon accept deposit=true

@whedon whedon added the accepted label Dec 2, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

Doing it live! Attempting automated processing of paper acceptance...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 openjournals/joss-papers#1142
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01821
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.01821/status.svg)](https://doi.org/10.21105/joss.01821)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01821">
  <img src="https://joss.theoj.org/papers/10.21105/joss.01821/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.01821/status.svg
   :target: https://doi.org/10.21105/joss.01821

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@nfrerebeau

This comment has been minimized.

Copy link

@nfrerebeau nfrerebeau commented Dec 2, 2019

@izaromanowska, @soodoku, @oliviaguest and @Kevin-Mattheus-Moerman many thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.