Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: rtweet: Collecting and analyzing Twitter data #1829

Closed
19 tasks done
whedon opened this issue Oct 22, 2019 · 27 comments
Closed
19 tasks done

[REVIEW]: rtweet: Collecting and analyzing Twitter data #1829

whedon opened this issue Oct 22, 2019 · 27 comments
Assignees
Labels
accepted published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review rOpenSci Submissions associated with rOpenSci

Comments

@whedon
Copy link

whedon commented Oct 22, 2019

Submitting author: @mkearney (Michael Wayne Kearney)
Repository: https://github.com/ropensci/rtweet
Version: v0.7.0
Editor: @kthyng
Reviewer: @kthyng
Archive: 10.5281/zenodo.3515425

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/5ec648d979e162cfc1d85e35cb0e3202"><img src="https://joss.theoj.org/papers/5ec648d979e162cfc1d85e35cb0e3202/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/5ec648d979e162cfc1d85e35cb0e3202/status.svg)](https://joss.theoj.org/papers/5ec648d979e162cfc1d85e35cb0e3202)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@kthyng, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kthyng know.

Please try and complete your review in the next two weeks

Review checklist for @kthyng

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@mkearney) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?
@whedon
Copy link
Author

whedon commented Oct 22, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @kthyng it looks like you're currently assigned to review this paper 🎉.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 22, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Oct 22, 2019

@kthyng
Copy link

kthyng commented Oct 22, 2019

This submission was already reviewed as part of rOpenSci.

@kthyng
Copy link

kthyng commented Oct 22, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 22, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Oct 22, 2019

@kthyng
Copy link

kthyng commented Oct 22, 2019

@mkearney There is a reference that's not coming through in your paper — can you check on that?

Also I will be needing your Zenodo archive.

@mkearney
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 22, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Oct 22, 2019

@mkearney
Copy link

@kthyng I believe I fixed the missing reference issue. And is this what you need for the zenodo doi/archive: http://doi.org/10.5281/zenodo.3515425?

@kthyng
Copy link

kthyng commented Oct 23, 2019

@mkearney Yes the reference issue looks resolved now.

Yes, that zenodo archive is what I need, though can you change the title so that it matches your paper?

@mkearney
Copy link

Done!

@kthyng
Copy link

kthyng commented Oct 24, 2019

@whedon set 10.5281/zenodo.3515425 as archive

@whedon
Copy link
Author

whedon commented Oct 24, 2019

OK. 10.5281/zenodo.3515425 is the archive.

@kthyng
Copy link

kthyng commented Oct 24, 2019

Ok I think I have everything now! I can go through the acceptance process now.

@kthyng
Copy link

kthyng commented Oct 24, 2019

@whedon accept

@whedon
Copy link
Author

whedon commented Oct 24, 2019

Attempting dry run of processing paper acceptance...

@whedon
Copy link
Author

whedon commented Oct 24, 2019


OK DOIs

- 10.5281/zenodo.2528481 is OK
- 10.5210/fm.v23i12.9540 is OK
- 10.1080/14459795.2019.1606927 is OK
- 10.5281/zenodo.1188429 is OK
- 10.1016/j.jairtraman.2019.01.010 is OK
- 10.1177/1461444818822813 is OK
- 10.3389/fphy.2019.00098 is OK
- 10.1177/2055207618821521 is OK
- 10.1016/j.jvacx.2019.100019 is OK
- 10.1177/1461444818809392 is OK
- 10.1038/s41746-018-0017-5 is OK
- 10.1016/j.tele.2017.09.015 is OK
- 10.1007/s11036-018-1055-6 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Oct 24, 2019

Check final proof 👉 openjournals/joss-papers#1049

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1049, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

@kthyng
Copy link

kthyng commented Oct 24, 2019

@whedon accept deposit=true

@kthyng kthyng closed this as completed Oct 24, 2019
@whedon
Copy link
Author

whedon commented Oct 24, 2019

Doing it live! Attempting automated processing of paper acceptance...

@kthyng kthyng reopened this Oct 24, 2019
@whedon
Copy link
Author

whedon commented Oct 24, 2019

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@whedon
Copy link
Author

whedon commented Oct 24, 2019

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.01829 joss-papers#1050
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01829
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

@kthyng
Copy link

kthyng commented Oct 24, 2019

Congratulations @mkearney on your new paper!!

@kthyng kthyng closed this as completed Oct 24, 2019
@whedon
Copy link
Author

whedon commented Oct 24, 2019

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.01829/status.svg)](https://doi.org/10.21105/joss.01829)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01829">
  <img src="https://joss.theoj.org/papers/10.21105/joss.01829/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.01829/status.svg
   :target: https://doi.org/10.21105/joss.01829

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@arfon arfon added the rOpenSci Submissions associated with rOpenSci label Feb 6, 2020
@whedon whedon added published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. labels Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review rOpenSci Submissions associated with rOpenSci
Projects
None yet
Development

No branches or pull requests

4 participants