Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: Plonk: Smoothed particle hydrodynamics analysis and visualization with Python #1884

Closed
whedon opened this issue Nov 11, 2019 · 48 comments
Closed
Assignees
Labels

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Nov 11, 2019

Submitting author: @dmentipl (Daniel Mentiplay)
Repository: https://github.com/dmentipl/plonk
Version: 0.2.1
Editor: @dfm
Reviewer: @zingale, @matthewturk
Archive: 10.5281/zenodo.3554568

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e785dbbbc29d77211041264315d7d3c6"><img src="https://joss.theoj.org/papers/e785dbbbc29d77211041264315d7d3c6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e785dbbbc29d77211041264315d7d3c6/status.svg)](https://joss.theoj.org/papers/e785dbbbc29d77211041264315d7d3c6)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@zingale & @matthewturk, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.

Please try and complete your review in the next two weeks

Review checklist for @zingale

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@dmentipl) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @matthewturk

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@dmentipl) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 11, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @zingale, @matthewturk it looks like you're currently assigned to review this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 11, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 11, 2019

@zingale

This comment has been minimized.

Copy link

@zingale zingale commented Nov 11, 2019

@dmentipl

This comment has been minimized.

Copy link

@dmentipl dmentipl commented Nov 22, 2019

Hi @zingale and @matthewturk. I've added to the documentation and provided a test data set at https://anaconda.org/dmentipl/plonk_example_data/.

@zingale

This comment has been minimized.

Copy link

@zingale zingale commented Nov 23, 2019

My main comment was address and I was able to follow the analysis to do the example analysis and visualization. I am happy to accept.

@matthewturk

This comment has been minimized.

Copy link

@matthewturk matthewturk commented Nov 24, 2019

Same!

@dfm

This comment has been minimized.

Copy link

@dfm dfm commented Nov 25, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 25, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 25, 2019

@dfm

This comment has been minimized.

Copy link

@dfm dfm commented Nov 25, 2019

@whedon check references

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 25, 2019

Attempting to check references...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 25, 2019


OK DOIs

- 10.1051/0004-6361/201322068 is OK
- 10.5281/zenodo.21703 is OK
- 10.1093/mnras/181.3.375 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1086/112164 is OK
- 10.5281/zenodo.2392268 is OK
- 10.1109/MCSE.2007.58 is OK
- 10.1071/AS07022 is OK
- 10.1016/j.jcp.2010.12.011 is OK
- 10.1017/pasa.2018.25 is OK
- 10.1088/0067-0049/192/1/9 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@dfm

This comment has been minimized.

Copy link

@dfm dfm commented Nov 25, 2019

@dmentipl: Looking good! Can you make the following small changes:

  • Update the scikit-image reference to the preferred citation as described here: https://scikit-image.org/
  • Update the scipy and numpy references as requested here: https://www.scipy.org/citing.html
  • Add the DOI for the Jupyter reference: 10.3233/978-1-61499-649-1-87
  • Add a capitalization guard to the title of {{Python and HDF5}}
  • ASCL references don't render well in TeX so please add howpublished = {Astrophysics Source Code Library} to the entry to make it clearer
  • In paragraph 3, "...a set of particles with mass" should be something like "...a set of massive particles".
  • At the bottom of page 1, the sentence starting with "Tasks such as:..." is not complete. It could be combined with the previous sentence or expanded into a full sentence of its own right.
  • On page 2, the sentence about yt should include more information to draw comparisons with Plonk. For example, my understanding is that yt was originally designed for grid codes with SPH support added more recently. If that's true, perhaps that sentence could include a comment about that.
  • The last sentence of the main body could use more detail. Would users of Phantom SPH find Plonk useful because that's what it was originally designed to visualize? If so, that would be useful to include.
dmentipl added a commit to dmentipl/plonk that referenced this issue Nov 26, 2019
See the following issue comment:
openjournals/joss-reviews#1884 (comment)
@dmentipl

This comment has been minimized.

Copy link

@dmentipl dmentipl commented Nov 26, 2019

Hi @dfm, I've made all changes requested.

Hopefully the changes I've made to the last paragraph in the main body cover the last two points above.

@matthewturk: I hope my changes convey the state of yt with regards to the demeshening.

@dfm

This comment has been minimized.

Copy link

@dfm dfm commented Nov 26, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 26, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 26, 2019

@dfm

This comment has been minimized.

Copy link

@dfm dfm commented Nov 26, 2019

@whedon check references

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 26, 2019

Attempting to check references...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 26, 2019


OK DOIs

- 10.1051/0004-6361/201322068 is OK
- 10.5281/zenodo.21703 is OK
- 10.1093/mnras/181.3.375 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.3233/978-1-61499-649-1-87 is OK
- 10.1086/112164 is OK
- 10.5281/zenodo.2392268 is OK
- 10.1071/AS07022 is OK
- 10.1016/j.jcp.2010.12.011 is OK
- 10.1017/pasa.2018.25 is OK
- 10.1088/0067-0049/192/1/9 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.7717/peerj.453 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@dfm

This comment has been minimized.

Copy link

@dfm dfm commented Nov 26, 2019

@dmentipl: Looks good to me! Can you update generate a new Zenodo archive with a title and author list that match the manuscript? Once you do that, report the new DOI here.

@dmentipl

This comment has been minimized.

Copy link

@dmentipl dmentipl commented Nov 27, 2019

@dfm: The Zenodo archive DOI is 10.5281/zenodo.3554568

Also, I updated the Plonk version to v0.2.1.

The Zenodo archive automatically generated from the GitHub release included Matthew as an author, as he contributed a pull request adding a reference to yt in the manuscript. However, I removed him from the Zenodo archive author list. I hope that's appropriate?

@matthewturk

This comment has been minimized.

Copy link

@matthewturk matthewturk commented Nov 27, 2019

@dfm

This comment has been minimized.

Copy link

@dfm dfm commented Nov 27, 2019

@dmentipl: That's right! Thanks this looks good.

@dfm

This comment has been minimized.

Copy link

@dfm dfm commented Nov 27, 2019

@whedon set 10.5281/zenodo.3554568 as archive

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 27, 2019

OK. 10.5281/zenodo.3554568 is the archive.

@dfm

This comment has been minimized.

Copy link

@dfm dfm commented Nov 27, 2019

@whedon set 0.2.1 as version

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 27, 2019

OK. 0.2.1 is the version.

@dfm

This comment has been minimized.

Copy link

@dfm dfm commented Nov 27, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 27, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Nov 27, 2019

@dfm

This comment has been minimized.

Copy link

@dfm dfm commented Nov 27, 2019

This looks good to go for me! Pinging @openjournals/joss-eics for final processing.

@dmentipl

This comment has been minimized.

Copy link

@dmentipl dmentipl commented Nov 27, 2019

@dfm The proof looks good to me. Let me know if there's anything left to do.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Dec 1, 2019

I checked the paper and Zenodo archive as well and all looks good.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Dec 1, 2019

@whedon accept

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 1, 2019

Attempting dry run of processing paper acceptance...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 1, 2019


OK DOIs

- 10.1051/0004-6361/201322068 is OK
- 10.5281/zenodo.21703 is OK
- 10.1093/mnras/181.3.375 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.3233/978-1-61499-649-1-87 is OK
- 10.1086/112164 is OK
- 10.5281/zenodo.2392268 is OK
- 10.1071/AS07022 is OK
- 10.1016/j.jcp.2010.12.011 is OK
- 10.1017/pasa.2018.25 is OK
- 10.1088/0067-0049/192/1/9 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.7717/peerj.453 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 1, 2019

Check final proof 👉 openjournals/joss-papers#1136

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1136, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Dec 1, 2019

@whedon accept deposit=true

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 1, 2019

Doing it live! Attempting automated processing of paper acceptance...
@whedon whedon added the accepted label Dec 1, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 1, 2019

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 1, 2019

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 openjournals/joss-papers#1137
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01884
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

@dfm

This comment has been minimized.

Copy link

@dfm dfm commented Dec 1, 2019

@dmentipl: congrats - your paper is now published! 🎉

@zingale, @matthewturk: thanks 💯 for your constructive reviews!

@dmentipl

This comment has been minimized.

Copy link

@dmentipl dmentipl commented Dec 1, 2019

Thank you @dfm for editing, and thank you @zingale and @matthewturk for reviewing!

@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Dec 2, 2019

@openjournals/dev this DOI is not resolving yet, can you check?

@danielskatz

This comment has been minimized.

Copy link

@danielskatz danielskatz commented Dec 2, 2019

The DOI resolves for me, and the paper looks fine.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Dec 2, 2019

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.01884/status.svg)](https://doi.org/10.21105/joss.01884)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01884">
  <img src="https://joss.theoj.org/papers/10.21105/joss.01884/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.01884/status.svg
   :target: https://doi.org/10.21105/joss.01884

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.