Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: plotrr: Functions for making visual exploratory data analysis with nested data easier. Edit #190
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Conflict of interest
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
I sent @cdcrabtree a pull request with several small changes, plus added a couple of issues with a few other minor suggestions.
It would be great if the authors could add a formal vignette to give a bit more detail on the use of the functions, and maybe some discussion of interpretation. But the ReadMe file and the examples in the function documentation are probably sufficient.
The CRAN requirement on providing license information within an R package is a bit odd, in that the
@kbroman Thanks for the helpful suggestions and changes. We've just finished going through and incorporating your pull request, addressing the issues, and addressing your comments here. We've updated the version number of the software to reflect these changes and creates a NEWS file that enumerates them. Specific to your comments here, we've removed all instances of
One thing that I wanted to add here is that our references do not have DOIs, unfortunately. Several are books, which were not assigned a DOI. The article should have one, but the publisher hasn't assigned one yet.
Please let us know if there are any other issues that we can address.
Thanks again for the very helpful comments.
Sent from my iPhone
On Mar 5, 2017, at 4:49 AM, Arfon Smith ***@***.***> wrote: @cdcrabtree - could you move the references you currently have in the paper.md file into a paper.bib file and cite them directly please? (You can read how to do that here) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Thanks @cdcrabtree. Please could you add yourself to this file? That way we'll know to call on you sometime in the future: https://github.com/openjournals/joss/blob/master/docs/reviewers.csv