Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: hdbscan: A high performance implementation of HDBSCAN* clustering. #191

Closed
whedon opened this issue Mar 4, 2017 · 15 comments

Comments

@whedon
Copy link
Collaborator

commented Mar 4, 2017

Submitting author: @lmcinnes (Leland McInnes)
Repository: https://github.com/scikit-learn-contrib/hdbscan
Version: v0.8.8
Editor: @danielskatz
Reviewer: @zhaozhang

What this issue is for

Thanks for submitting your paper to JOSS @lmcinnes. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Mar 4, 2017

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 4, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS.

For a list of things I can do to help you, just type:

@whedon commands
@arfon

This comment has been minimized.

Copy link
Member

commented Mar 4, 2017

👋 @jakevdp - would you be able to edit this one?

@arfon

This comment has been minimized.

Copy link
Member

commented Mar 12, 2017

👋 @danielskatz - any interest in editing this submission?

@danielskatz

This comment has been minimized.

Copy link

commented Mar 13, 2017

Ok.

@arfon

This comment has been minimized.

Copy link
Member

commented Mar 13, 2017

@whedon assign @danielskatz as editor

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 13, 2017

OK, the editor is @danielskatz

@danielskatz

This comment has been minimized.

Copy link

commented Mar 13, 2017

Hi @lmcinnes
While I look for a reviewer, you might want to fix the formatting of the paper part of your submission. See https://github.com/mpastell/Weave.jl/blob/master/paper/paper.md for an example of another current submission that has a properly formatted paper. By this, I refer to two things:

  1. the metadata, which looks ok to me, but doesn't seem to generate a proper table like I expected, though perhaps this is a parsing issue, since I don't see anything wrong with your metadata itself. Ah, I see it now - your line 12 needs one more space at the start.
  2. references to items in the bibliography. Only items that are referenced in the text will be shown in the bibliography when the paper is compiled, and you currently don't refer to any of them.

Thanks.

@danielskatz

This comment has been minimized.

Copy link

commented Mar 13, 2017

@whedon start review magic-word=bananas

@danielskatz

This comment has been minimized.

Copy link

commented Mar 13, 2017

@whedon assign @zhaozhang as reviewer

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 13, 2017

OK, the reviewer is @zhaozhang

@whedon whedon assigned danielskatz and zhaozhang and unassigned danielskatz Mar 13, 2017

@danielskatz

This comment has been minimized.

Copy link

commented Mar 13, 2017

@whedon start review magic-word=bananas

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 13, 2017

You didn't say the magic word! Try this:

@whedon start review magic-word=bananas
@danielskatz

This comment has been minimized.

Copy link

commented Mar 13, 2017

@whedon start review magic-word=bananas

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 13, 2017

OK, I've started the review over in #205. Feel free to close this issue now!

@danielskatz

This comment has been minimized.

Copy link

commented Mar 13, 2017

@zhaozhang - the review is is #205. Thanks for agreeing to do this. Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.