Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: covtobed: a simple and fast tool to extract coverage tracks from BAM files #2119

Closed
whedon opened this issue Feb 25, 2020 · 33 comments
Closed

Comments

@whedon
Copy link
Collaborator

@whedon whedon commented Feb 25, 2020

Submitting author: @telatin (Andrea Telatin)
Repository: https://github.com/telatin/covtobed/
Version: v1.1.0
Editor: @will-rowe
Reviewer: @jdeligt, @brentp
Archive: 10.5281/zenodo.3695204

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0ed74df9f40a58a852bf3fff512acd2b"><img src="https://joss.theoj.org/papers/0ed74df9f40a58a852bf3fff512acd2b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0ed74df9f40a58a852bf3fff512acd2b/status.svg)](https://joss.theoj.org/papers/0ed74df9f40a58a852bf3fff512acd2b)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@jdeligt & @brentp, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @will-rowe know.

Please try and complete your review in the next two weeks

Review checklist for @jdeligt

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@telatin) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @brentp

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@telatin) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 25, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @jdeligt, @brentp it looks like you're currently assigned to review this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 25, 2020

Reference check summary:

OK DOIs

- 10.1093/bioinformatics/btq033 is OK
- 10.1093/bioinformatics/btx699 is OK
- 10.1038/nrg3642 is OK
- 10.1093/bioinformatics/btp352 is OK
- 10.1093/bioinformatics/btr174 is OK
- 10.1016/j.hrthm.2018.11.015 is OK
- 10.5281/zenodo.3643386 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 25, 2020

@brentp

This comment has been minimized.

Copy link

@brentp brentp commented Feb 27, 2020

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Feb 27, 2020

@jdeligt

This comment has been minimized.

Copy link

@jdeligt jdeligt commented Feb 29, 2020

Hi @telatin,

Overall looking good, please consider the integrity and performance check marks in;
telatin/covtobed#6

And please update example usage as specified in;
telatin/covtobed#5

Best regards,
Joep

@brentp

This comment has been minimized.

Copy link

@brentp brentp commented Mar 2, 2020

LGTM

@telatin

This comment has been minimized.

Copy link

@telatin telatin commented Mar 2, 2020

Dear @brentp and @jdeligt,
thank you very much for your quick and thorough review, we really feel that your input allowed us to improve the package quality.

Summarizing:

  • paper updated clarifying some sentences
  • automated tests have been expanded and documented
  • the wiki documentation has been expanded, specifically including information on the coverage calculation and stressing the peculiar usage of "covtobed" (physical-coverage, strand-specific analysis, streaming)
  • the benchmark section has been expanded to include a test with a whole human genome and its description extended
  • released 1.0.1 with support for coverage > 2**16, initially naively excluded

See: https://github.com/telatin/covtobed/issues?utf8=%E2%9C%93&q=is%3Aissue+label%3Ajoss+ for the issues opened in the repo

@jdeligt

This comment has been minimized.

Copy link

@jdeligt jdeligt commented Mar 2, 2020

Hi @telatin ,

Thank you for the quick responses and the additions made to the repo.
I added one last comment to issue#5 but this is a nice to have but should not hold up publication.
The clarifactions will help users better determine what the software does and is a nice intro into some of the vageries of coverage depth calculations.

@will-rowe, looks like @brentp is happy with it as well so I think we'll hand it back to you.

@will-rowe

This comment has been minimized.

Copy link

@will-rowe will-rowe commented Mar 3, 2020

Perfect - thanks for your speedy and excellent reviews @jdeligt and @brentp!

This is looking really nice @telatin - I'll just give it a finally read through

@will-rowe

This comment has been minimized.

Copy link

@will-rowe will-rowe commented Mar 3, 2020

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Mar 3, 2020

@will-rowe

This comment has been minimized.

Copy link

@will-rowe will-rowe commented Mar 3, 2020

@whedon check references

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Mar 3, 2020

Reference check summary:

OK DOIs

- 10.1093/bioinformatics/btq033 is OK
- 10.1093/bioinformatics/btx699 is OK
- 10.1038/nrg3642 is OK
- 10.1093/bioinformatics/btp352 is OK
- 10.1093/bioinformatics/btr174 is OK
- 10.1016/j.hrthm.2018.11.015 is OK
- 10.5281/zenodo.3643386 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@will-rowe

This comment has been minimized.

Copy link

@will-rowe will-rowe commented Mar 3, 2020

Okay I think we can move toward acceptance here!

@telatin - I need you to tag a new release and archive it. Then can you get back to me with the version number and the archive DOI.

@telatin

This comment has been minimized.

Copy link

@telatin telatin commented Mar 3, 2020

Thanks to you all for your great work!

@will-rowe

This comment has been minimized.

Copy link

@will-rowe will-rowe commented Mar 3, 2020

@whedon set 10.5281/zenodo.3695204 as archive

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Mar 3, 2020

OK. 10.5281/zenodo.3695204 is the archive.

@will-rowe

This comment has been minimized.

Copy link

@will-rowe will-rowe commented Mar 3, 2020

@whedon set v1.1.0 as version

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Mar 3, 2020

OK. v1.1.0 is the version.

@will-rowe

This comment has been minimized.

Copy link

@will-rowe will-rowe commented Mar 3, 2020

@whedon accept

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Mar 3, 2020

Attempting dry run of processing paper acceptance...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Mar 3, 2020

Reference check summary:

OK DOIs

- 10.1093/bioinformatics/btq033 is OK
- 10.1093/bioinformatics/btx699 is OK
- 10.1038/nrg3642 is OK
- 10.1093/bioinformatics/btp352 is OK
- 10.1093/bioinformatics/btr174 is OK
- 10.1016/j.hrthm.2018.11.015 is OK
- 10.5281/zenodo.3643386 is OK

MISSING DOIs

- None

INVALID DOIs

- None
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Mar 3, 2020

👋 @openjournals/joss-eics, this paper is ready to be accepted and published

. Check final proof 👉 openjournals/joss-papers#1351

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1351, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Mar 6, 2020

I've read the paper and it looks good

@Kevin-Mattheus-Moerman

This comment has been minimized.

Copy link
Member

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman commented Mar 6, 2020

@whedon accept deposit=true

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Mar 6, 2020

Doing it live! Attempting automated processing of paper acceptance...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Mar 6, 2020

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Mar 6, 2020

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 openjournals/joss-papers#1356
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.02119
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

@arfon

This comment has been minimized.

Copy link
Member

@arfon arfon commented Mar 14, 2020

Dear authors and reviewers

We wanted to notify you that in light of the current COVID-19 pandemic, JOSS has decided to suspend submission of new manuscripts and to handle existing manuscripts (such as this one) on a "best efforts basis". We understand that you may need to attend to more pressing issues than completing a review or updating a repository in response to a review. If this is the case, a quick note indicating that you need to put a "pause" on your involvement with a review would be appreciated but is not required.

Thanks in advance for your understanding.

Arfon Smith, Editor in Chief, on behalf of the JOSS editorial team.

@will-rowe

This comment has been minimized.

Copy link

@will-rowe will-rowe commented Mar 16, 2020

Pinging @openjournals/jose-eics - I think this can be closed now?

@arfon arfon closed this Mar 16, 2020
@whedon

This comment has been minimized.

Copy link
Collaborator Author

@whedon whedon commented Mar 16, 2020

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02119/status.svg)](https://doi.org/10.21105/joss.02119)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02119">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02119/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02119/status.svg
   :target: https://doi.org/10.21105/joss.02119

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@arfon

This comment has been minimized.

Copy link
Member

@arfon arfon commented Mar 16, 2020

Pinging @openjournals/jose-eics - I think this can be closed now?

Just a heads up @will-rowe that you mentioned the wrong EiC group here :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.