Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: bíogo/ncbi: interfaces to NCBI services for the Go language #234
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Conflict of interest
referenced this issue
Apr 8, 2017
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
I'm sorry too late.
I'd like to run examples in README.md.
Sorry. I have fixed the entrez example. That was a copy-paste error. The issue with the BLAST example is that it is not intended to be a complete runnable program; providing the harness for all that would detract from the code I have provided. I have clarified this in the preamble to that example.
Please comment at this PR.
We make no claims about performance since the vast majority of computational effort is made by the NCBI servers or the local BLAST executable. I don't believe that syntactic weight constitutes performance, but I guess that could be assessed by comparison of exported function count or SLOC with other similar suites.