Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: 3dfier: automatic reconstruction of 3D city models #2853

Closed
whedon opened this issue Nov 20, 2020 · 25 comments
Closed

[PRE REVIEW]: 3dfier: automatic reconstruction of 3D city models #2853

whedon opened this issue Nov 20, 2020 · 25 comments

Comments

@whedon
Copy link

whedon commented Nov 20, 2020

Submitting author: @hugoledoux (Hugo Ledoux)
Repository: https://github.com/tudelft3d/3dfier
Version: v1.3.0
Editor: @arfon
Reviewers: @GANys, @chenkianwee
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @hugoledoux. Currently, there isn't an JOSS editor assigned to your paper.

@hugoledoux if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Nov 20, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 20, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.72 s (242.9 files/s, 61188.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                    16           2533           4876           8500
CSS                             10           1473             65           7842
C++                             14            592            749           5848
SVG                              3              0              0           3479
YAML                            36            151             58           2216
Markdown                        26            511              0           1529
JavaScript                       7            317            535            920
HTML                            36            176             55            867
XML                              4              4              0            298
Python                           4             31             15            189
Bourne Shell                     8             28             25            108
TeX                              1             18              0             68
Dockerfile                       2             12              4             63
JSON                             4              8              0             57
CMake                            2             24             13             51
DOS Batch                        3              2              0             32
-------------------------------------------------------------------------------
SUM:                           176           5880           6395          32067
-------------------------------------------------------------------------------


Statistical information for the repository 'e2ba67312e06f295b225cbf1' was
gathered on 2020/11/20.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Clemens Rudert                   1            12              5            0.02
Hugo Ledoux                    354         27473          22716           60.05
Ivan Paden                       7           359            128            0.58
Ravi Peters                      6            25              7            0.04
Tom Commandeur                 397         18494          13534           38.32
Ylannl                          16           504            225            0.87
tcommandeur                      1             2              4            0.01
tjfcommandeur                    2            78             14            0.11

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Clemens Rudert               11           91.7         12.5                0.00
Hugo Ledoux               17437           63.5         36.2               36.84
Ivan Paden                  266           74.1          0.5                4.51
Tom Commandeur             7148           38.7         28.2               14.03
Ylannl                      243           48.2         34.3                5.35

@whedon
Copy link
Author

whedon commented Nov 20, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.buildenv.2014.04.013 is OK
- 10.1080/13658810701739039 is OK
- 10.4236/jep.2013.47081  is OK
- j.compenvurbsys.2011.02.001 is OK
- 10.14358/PERS.79.2.147 is OK
- 10.1186/s40965-019-0064-0 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Nov 20, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

👋 @bstabler - you've been requested as the editor for this submission - can you take it on?

@danielskatz
Copy link

@whedon invite @bstabler as editor

@whedon
Copy link
Author

whedon commented Nov 20, 2020

@bstabler has been invited to edit this submission.

@hugoledoux
Copy link

potential reviewers:

  1. clausnagel
  2. ganys
  3. chenkianwee
  4. https://3dom.fbk.eu/people/profile/eozdemir (not sure on github though)
  5. https://research.utwente.nl/en/persons/sander-oude-elberink (not sure on github though)

@arfon
Copy link
Member

arfon commented Nov 24, 2020

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Nov 24, 2020

OK, the editor is @arfon

@arfon
Copy link
Member

arfon commented Nov 24, 2020

👋 @clausnagel @chenkianwee @GANys - would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The submission we'd be asking you to review is 3dfier: automatic reconstruction of 3D city models.

@GANys
Copy link

GANys commented Nov 24, 2020

@arfon, I certainly agree.

Is there any deadline?

@arfon
Copy link
Member

arfon commented Nov 24, 2020

@GANys - excellent, thanks! We generally aim to have JOSS reviews complete within six weeks, but given their iterative nature, it's often most effective if you can start your review in the first couple of weeks (to give initial feedback to the authors).

Does that sound OK?

@GANys
Copy link

GANys commented Nov 24, 2020

It seems more than feasible.

@arfon
Copy link
Member

arfon commented Nov 24, 2020

@whedona add @GANys as reviewer

@whedon

This comment has been minimized.

@arfon
Copy link
Member

arfon commented Nov 24, 2020

@whedon add @GANys as reviewer

@whedon
Copy link
Author

whedon commented Nov 24, 2020

OK, @GANys is now a reviewer

@arfon
Copy link
Member

arfon commented Nov 24, 2020

It seems more than feasible.

Great, thanks! I won't open the actual review until we've identified a second reviewer but hopefully this won't take too long.

@chenkianwee
Copy link

Hi I agree to review the paper.

@arfon
Copy link
Member

arfon commented Nov 26, 2020

@whedon add @chenkianwee as reviewer

@whedon whedon assigned arfon, chenkianwee and GANys and unassigned GANys Nov 26, 2020
@whedon
Copy link
Author

whedon commented Nov 26, 2020

OK, @chenkianwee is now a reviewer

@arfon
Copy link
Member

arfon commented Nov 26, 2020

@whedon start review

@whedon
Copy link
Author

whedon commented Nov 26, 2020

OK, I've started the review over in #2866.

@whedon whedon closed this as completed Nov 26, 2020
@arfon
Copy link
Member

arfon commented Nov 26, 2020

@GANys, @chenkianwee - many thanks for agreeing to review this submission! See you over in #2866 where the actual review will take place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants