Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: kerasR: R Interface to the Keras Deep Learning Library #296
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Conflict of interest
referenced this issue
Jun 14, 2017
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
This is a package I have begun using when applying deep learning models. This interface mirrors Python's making it very easy to transition between the two languages. Constructing a model, fitting it, and predicting is easy. The examples in the documentation were helpful and I liked that the vignette includes references for other deep learning resources.
The package should be accepted. While going through the code and documentation, I came up with the following three suggestions.
@kaneplusplus Thank you very much for reviewing this submission and your very helpful feedback. I just pushed version 0.7.0 to GitHub, which I believe implements your three suggestions. Namely:
Please let me know if you have any further questions or suggestions.