Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: visdat: Visualising Whole Data Frames #355
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
@arfon, please carry out your review in this issue by updating the checklist below (please make sure you're logged in to GitHub). The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arfon know.
Conflict of interest
Code of Conduct
referenced this issue
Aug 10, 2017
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
Hi @njtierney, many thanks for your submission. This should be quick as you've already been through the rOpenSci process.
A couple of issues with your submission
It looks like you've got a couple of different paper files,
In addition, the markdown citations don't seem to be being picked up correctly (see the pandoc errors below)
Finally, the current paper reads a little too much like technical documentation (i.e. naming methods etc) which is not the purpose of the JOSS paper (this material should be in the technical documentation). Please take a look at this guidance as to what your paper should contain
Hi @arfon !
OK sure thing, I'm reviewing these changes at the moment and will have something to you at the end of next week at the latest.
Question - is it OK if I use
I think that should be OK. Our automated submission tooling will pick up any file named
It looks good now, thanks!
At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.