Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: prisonbrief: An R package that returns tidy data from the World Prison Brief website #361
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
@benmarwick, please carry out your review in this issue by updating the checklist below (please make sure you're logged in to GitHub). The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @karthik know.
Conflict of interest
Code of Conduct
referenced this issue
Aug 11, 2017
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
Thanks, in the code in in
So I'd recommend removing the
Thanks again for your comments. We left the
Hi @karthik and @benmarwick. My co-author and I have already addressed the missings items from the checking list. We added the data source as recommended by the original authors and included a message about the Linux dependency in this commit. Also, we added tests as requested, please see this commit. Finally, we included a
I have a few comments myself.
My session info
Session info ------------------------------------------------------------------ setting value version R version 3.4.3 (2017-11-30) system x86_64, darwin15.6.0 ui RStudio (1.1.383) language (EN) collate en_US.UTF-8 tz America/Los_Angeles date 2018-01-22
Hi @karthik, thanks very much for your comments. We've fixed the errors you pointed out.
Please let us know if you encounter any problem with the code. Many thanks!
If you would like to include a link to your paper from your README use the following code snippet:
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider volunteering to review for us sometime in the future. You can add your name to the reviewer list here: http://joss.theoj.org/reviewer-signup.html