Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: GiNaCDE: the high-performance F-expansion and First Integral Methods with C++ library for solving Nonlinear Differential Equations #3721

Closed
whedon opened this issue Sep 12, 2021 · 34 comments

Comments

@whedon
Copy link

whedon commented Sep 12, 2021

Submitting author: @mithun218 (Mithun Bairagi)
Repository: https://github.com/mithun218/GiNaCDE
Version: v1.0.0
Editor: @meg-simula
Reviewers: @peanutfun, @carstenbauer
Managing EiC: Kevin M. Moerman

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/340d71bea413f1f5677108636bf38665"><img src="https://joss.theoj.org/papers/340d71bea413f1f5677108636bf38665/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/340d71bea413f1f5677108636bf38665/status.svg)](https://joss.theoj.org/papers/340d71bea413f1f5677108636bf38665)

Author instructions

Thanks for submitting your paper to JOSS @mithun218. Currently, there isn't an JOSS editor assigned to your paper.

@mithun218 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Sep 12, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 12, 2021

Wordcount for paper.md is 962

@whedon
Copy link
Author

whedon commented Sep 12, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.10 s (433.4 files/s, 136644.3 lines/s)
-----------------------------------------------------------------------------------
Language                         files          blank        comment           code
-----------------------------------------------------------------------------------
C++                                 24           2117            729           8719
TeX                                  2            144             15            925
C/C++ Header                        11            217            106            642
CMake                                3             54             64            219
Markdown                             3             47              0            167
YAML                                 1              1              4             18
Windows Resource File                1              0              0              1
-----------------------------------------------------------------------------------
SUM:                                45           2580            918          10691
-----------------------------------------------------------------------------------


Statistical information for the repository '50ef42e6afd55c37d5444ce8' was
gathered on 2021/09/12.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
mithun218                        1         12819              0          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
mithun218                 12819          100.0          0.0                6.56

@whedon
Copy link
Author

whedon commented Sep 12, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1155/2013/104894 is OK
- 10.1016/j.chaos.2005.10.007 is OK
- 10.1016/S0960-0779(03)00102-4 is OK
- 10.1016/S0375-9601(01)00825-8 is OK
- 10.15388/NA.17.4.14052 is OK
- 10.1016/j.cpc.2004.08.007 is OK

MISSING DOIs

- None

INVALID DOIs

- https://doi.org/10.1016/S0375-9601(02)01775-9 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.amc.2010.04.026 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1006/jsco.2001.0494 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.jmaa.2010.08.050 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/0010-4655(96)00104-X is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/S0010-4655(02)00559-3 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.jsc.2003.09.004 is INVALID because of 'https://doi.org/' prefix

@whedon
Copy link
Author

whedon commented Sep 12, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@mithun218 thanks for this submission. I will be looking for a handling editor for this work. In the mean time can you work on fixing those references ☝️. You can call @whedon generate pdf here, in a comment, to update the paper and call @whedon check references to check those DOI's. Thanks.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon invite @meg-simula as editor

@whedon
Copy link
Author

whedon commented Sep 12, 2021

@meg-simula has been invited to edit this submission.

@mithun218
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 12, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@mithun218
Copy link

@whedon check references

@whedon
Copy link
Author

whedon commented Sep 12, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/S0375-9601(02)01775-9 is OK
- 10.1155/2013/104894 is OK
- 10.1016/j.chaos.2005.10.007 is OK
- 10.1016/S0960-0779(03)00102-4 is OK
- 10.1016/S0375-9601(01)00825-8 is OK
- 10.15388/NA.17.4.14052 is OK
- 10.1016/j.amc.2010.04.026 is OK
- 10.1006/jsco.2001.0494 is OK
- 10.1016/j.jmaa.2010.08.050 is OK
- 10.1016/0010-4655(96)00104-X is OK
- 10.1016/S0010-4655(02)00559-3 is OK
- 10.1016/j.jsc.2003.09.004 is OK
- 10.1016/j.cpc.2004.08.007 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@mithun218
Copy link

@Kevin-Mattheus-Moerman I checked and corrected DOIs.

@meg-simula
Copy link

@whedon assign @meg-simula as editor

@whedon
Copy link
Author

whedon commented Sep 12, 2021

OK, the editor is @meg-simula

@meg-simula
Copy link

Yes, can do.

@meg-simula
Copy link

👋 Thanks, @mithun218 for the submission. This looks very much ready for review with JOSS.

I'll reach out to reviewers, and get back to you. Would you have any suggestions for reviewers, for instance from this spreadsheet?

@mithun218
Copy link

Hi and thank you @meg-simula for accepting to be editor for our paper!

For reviewers, I'll suggest
solanpaa, peanutfun, jamiejquinn, balos1, dawbarton, dglmoore,cpgr

@meg-simula
Copy link

👋 @peanutfun @balos1 @ketch would any of you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@peanutfun
Copy link

@meg-simula yes, I would like to! ☺️

@meg-simula
Copy link

meg-simula commented Oct 6, 2021

Great, thanks for the prompt reply @peanutfun. Will await a few more days for further responses.

@meg-simula
Copy link

@whedon assign @peanutfun as reviewer

@whedon whedon assigned meg-simula and peanutfun and unassigned meg-simula Oct 6, 2021
@whedon
Copy link
Author

whedon commented Oct 6, 2021

OK, @peanutfun is now a reviewer

@meg-simula
Copy link

Quick update: I'm actively searching for a second reviewer @mithun218, will let you know of further updates.

@mithun218
Copy link

@meg-simula from this spreadsheet, I can suggest some more reviewers :
justinsgray, sivaramambikasaran, crstnbr, schruste

@meg-simula
Copy link

Thanks @mithun218, let's ask them here.

@meg-simula
Copy link

👋 @JustinSGray @sivaramambikasaran @crstnbr @schruste would any of you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@carstenbauer
Copy link
Member

carstenbauer commented Nov 3, 2021

@meg-simula, yes, I can take this on. 🙂

(I renamed my gh account from @crstnbr to @carstenbauer for obvious reasons 😄)

@meg-simula
Copy link

Excellent, thanks for the prompt response @carstenbauer! Then we can get this review started.

@meg-simula
Copy link

@whedon add @carstenbauer as reviewer

@whedon
Copy link
Author

whedon commented Nov 3, 2021

OK, @carstenbauer is now a reviewer

@meg-simula
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Nov 3, 2021

OK, I've started the review over in #3885.

@whedon whedon closed this as completed Nov 3, 2021
@JustinSGray
Copy link

I can review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants