New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: mcMST: A Toolbox for the Multi-Criteria Minimum Spanning Tree Problem #374

Closed
whedon opened this Issue Aug 21, 2017 · 21 comments

Comments

Projects
None yet
10 participants
@whedon
Collaborator

whedon commented Aug 21, 2017

Submitting author: @jakobbossek (Jakob Bossek)
Repository: https://github.com/jakobbossek/mcMST
Version: v1.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewer: @gvegayon
Archive: 10.5281/zenodo.894402

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/31244283ec1570d0ca4753e2a39028ab"><img src="http://joss.theoj.org/papers/31244283ec1570d0ca4753e2a39028ab/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/31244283ec1570d0ca4753e2a39028ab/status.svg)](http://joss.theoj.org/papers/31244283ec1570d0ca4753e2a39028ab)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer questions

@gvegayon, please carry out your review in this issue by updating the checklist below (please make sure you're logged in to GitHub). The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @Kevin-Mattheus-Moerman know.

Conflict of interest

  • As the reviewer I confirm that there are no conflicts of interest for me to review this work (such as being a major contributor to the software).

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: Does the release version given match the GitHub release (v1.0.0)?
  • Authorship: Has the submitting author (@jakobbossek) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: Have any performance claims of the software been confirmed?

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Aug 21, 2017

Collaborator

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @gvegayon it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
Collaborator

whedon commented Aug 21, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @gvegayon it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman
Member

Kevin-Mattheus-Moerman commented Aug 21, 2017

@whedon assign @Kevin-Mattheus-Moerman as editor

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Aug 21, 2017

Collaborator

OK, the editor is @Kevin-Mattheus-Moerman

Collaborator

whedon commented Aug 21, 2017

OK, the editor is @Kevin-Mattheus-Moerman

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman
Member

Kevin-Mattheus-Moerman commented Aug 21, 2017

@whedon assign @gvegayon as reviewer

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Aug 21, 2017

Collaborator

OK, the reviewer is @gvegayon

Collaborator

whedon commented Aug 21, 2017

OK, the reviewer is @gvegayon

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Aug 21, 2017

Member

🚀 @jakobbossek This is where the review process will happen.

@gvegayon see here for the reviewer guidelines. See here for an example review process. Feel free to comment here or create issues on the repository and link to them here. Tick the boxes at the top here if you feel the requirements are met. Let me know if you have questions.

Member

Kevin-Mattheus-Moerman commented Aug 21, 2017

🚀 @jakobbossek This is where the review process will happen.

@gvegayon see here for the reviewer guidelines. See here for an example review process. Feel free to comment here or create issues on the repository and link to them here. Tick the boxes at the top here if you feel the requirements are met. Let me know if you have questions.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Aug 21, 2017

Member

@ArdiaD @lmarti @berndbischl @jakob-r @aklxao2 @luca-scr we would like to recruit multiple reviewers. If you would also like to review for us please join here by commenting on this submission and opening issues on the repository. Thanks!

Member

Kevin-Mattheus-Moerman commented Aug 21, 2017

@ArdiaD @lmarti @berndbischl @jakob-r @aklxao2 @luca-scr we would like to recruit multiple reviewers. If you would also like to review for us please join here by commenting on this submission and opening issues on the repository. Thanks!

@ArdiaD

This comment has been minimized.

Show comment
Hide comment
@ArdiaD

ArdiaD Aug 21, 2017

Currently under water with various projects, but would be happy to help later this year.

ArdiaD commented Aug 21, 2017

Currently under water with various projects, but would be happy to help later this year.

@berndbischl

This comment has been minimized.

Show comment
Hide comment
@berndbischl

berndbischl Aug 21, 2017

hi guys,

i am
a) currently traveling
and
b) have worked together with Jakob on multiple occasions, including supervising his master's thesis, so I don't feel there is an arm's length distance here

will therefore decline.

(PS: I want to say how much I like everything I see what happens at JOSS)

berndbischl commented Aug 21, 2017

hi guys,

i am
a) currently traveling
and
b) have worked together with Jakob on multiple occasions, including supervising his master's thesis, so I don't feel there is an arm's length distance here

will therefore decline.

(PS: I want to say how much I like everything I see what happens at JOSS)

@gvegayon

This comment has been minimized.

Show comment
Hide comment
@gvegayon

gvegayon Aug 22, 2017

Collaborator

Overall the project looks very good, although a couple of things can be done to (I think) improve it by solving the following issues that I just listed:

  1. The AppVeyor link is broken (jakobbossek/mcMST#8)
  2. The [@]return tag in mcMSTPrim.R is bad (jakobbossek/mcMST#9)
  3. Specify (or actually point to) the definition of the output of mcMSTEmoaZhou and friends (jakobbossek/mcMST#10)
  4. Coding standards/misc (jakobbossek/mcMST#11)

HIH

Collaborator

gvegayon commented Aug 22, 2017

Overall the project looks very good, although a couple of things can be done to (I think) improve it by solving the following issues that I just listed:

  1. The AppVeyor link is broken (jakobbossek/mcMST#8)
  2. The [@]return tag in mcMSTPrim.R is bad (jakobbossek/mcMST#9)
  3. Specify (or actually point to) the definition of the output of mcMSTEmoaZhou and friends (jakobbossek/mcMST#10)
  4. Coding standards/misc (jakobbossek/mcMST#11)

HIH

@jakobbossek

This comment has been minimized.

Show comment
Hide comment
@jakobbossek

jakobbossek Aug 22, 2017

Hi guys,

thanks for editing @Kevin-Mattheus-Moerman and reviewing @gvegayon 👍
I'm on vacation right now forcing myself not to work nevertheless and read work-related mails too often 😉

@gvegayon Thanks for the fast review process! I am happy to go through the issues you opened as soon as vacation ends.

jakobbossek commented Aug 22, 2017

Hi guys,

thanks for editing @Kevin-Mattheus-Moerman and reviewing @gvegayon 👍
I'm on vacation right now forcing myself not to work nevertheless and read work-related mails too often 😉

@gvegayon Thanks for the fast review process! I am happy to go through the issues you opened as soon as vacation ends.

@luca-scr

This comment has been minimized.

Show comment
Hide comment
@luca-scr

luca-scr Aug 22, 2017

luca-scr commented Aug 22, 2017

@aklxao2

This comment has been minimized.

Show comment
Hide comment
@aklxao2

aklxao2 Aug 24, 2017

Hello,

currently I am with several projects that consumes all my time, so I'm afraid I must decline the review. Sorry.

Best regards.
Ángel.

aklxao2 commented Aug 24, 2017

Hello,

currently I am with several projects that consumes all my time, so I'm afraid I must decline the review. Sorry.

Best regards.
Ángel.

@jakob-r

This comment has been minimized.

Show comment
Hide comment
@jakob-r

jakob-r Sep 4, 2017

Hi,
together with @berndbischl I worked with @jakobbossek on multiple projects so I guess my review would be biased.

jakob-r commented Sep 4, 2017

Hi,
together with @berndbischl I worked with @jakobbossek on multiple projects so I guess my review would be biased.

@gvegayon

This comment has been minimized.

Show comment
Hide comment
@gvegayon

gvegayon Sep 7, 2017

Collaborator

Just closed the last issue created in jakobbossek/mcMST (jakobbossek/mcMST#11). I'm OK with what the project looks like now 👍

Collaborator

gvegayon commented Sep 7, 2017

Just closed the last issue created in jakobbossek/mcMST (jakobbossek/mcMST#11). I'm OK with what the project looks like now 👍

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Sep 12, 2017

Member

Thanks for the review @gvegayon! @arfon, over to you, we are good to accept this one!

Member

Kevin-Mattheus-Moerman commented Sep 12, 2017

Thanks for the review @gvegayon! @arfon, over to you, we are good to accept this one!

@arfon arfon added the accepted label Sep 13, 2017

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Sep 13, 2017

Member

@jakobbossek - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.

Member

arfon commented Sep 13, 2017

@jakobbossek - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.

@jakobbossek

This comment has been minimized.

Show comment
Hide comment
@jakobbossek

jakobbossek Sep 18, 2017

@gvegayon Thanks for the thorough review! 👍

@arfon Just uploaded a new version to CRAN and Zenedo. The DOI is https://doi.org/10.5281/zenodo.894402

jakobbossek commented Sep 18, 2017

@gvegayon Thanks for the thorough review! 👍

@arfon Just uploaded a new version to CRAN and Zenedo. The DOI is https://doi.org/10.5281/zenodo.894402

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Sep 21, 2017

Member

@whedon set 10.5281/zenodo.894402 as archive

Member

arfon commented Sep 21, 2017

@whedon set 10.5281/zenodo.894402 as archive

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Sep 21, 2017

Collaborator

OK. 10.5281/zenodo.894402 is the archive.

Collaborator

whedon commented Sep 21, 2017

OK. 10.5281/zenodo.894402 is the archive.

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Sep 21, 2017

Member

@gvegayon - many thanks for your review here and to @Kevin-Mattheus-Moerman for editing this submission

@jakobbossek - your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00374 ⚡️ 🚀 💥

Member

arfon commented Sep 21, 2017

@gvegayon - many thanks for your review here and to @Kevin-Mattheus-Moerman for editing this submission

@jakobbossek - your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00374 ⚡️ 🚀 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment