Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: Histogram-weighted Networks for Feature Extraction, Connectivity and Advanced Analysis in Neuroscience #380
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
@oesteban, please carry out your review in this issue by updating the checklist below (please make sure you're logged in to GitHub). The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @cMadan know.
Conflict of interest
Code of Conduct
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
@oesteban, it would be great if you could work through the reviewer checklist in the first comment and see if the submission addresses each point sufficiently. If not, please post issues in the submission's repo or here, as makes sense and hopefully @raamana can respond accordingly.
@JohnGriffiths, if you have time, it would still be great if you can also take a look at the submission too (even though you're not officially assigned as a reviewer).
I want to get this review done today :). If time does not permit, I will secure tomorrow for it.…
On Wed, Aug 30, 2017 at 8:26 AM, Pradeep Reddy Raamana < ***@***.***> wrote: Thanks Chris. Look fwd to hearing from @oesteban <https://github.com/oesteban> and/or @JohnGriffiths <https://github.com/johngriffiths> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#380 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAkhxibxTdFliKlIMTOfxUcB6Jgkt5Yvks5sdX84gaJpZM4PDqpS> .
This was referenced
Aug 30, 2017
This submission describes a software tool to calculate histogram weighted networks (HiWiNet). As far as I understood the code, the core of the tool is the
In my opinion, this submission can be accepted after a Major revision responding to the points raised in the issues enlisted above. Particularly, the editors of JOSS may want to track raamana/hiwenet#8 closely, as I think we hit there an area of JOSS' requirements for submissions which is (at the very least) gray and confusing - just a spoiler: what is a "minor" 'utility'?, what is exactly a utility?, and when a utility is a minor contribution?.
Items that need work (as per the checklist above)
The statement of need is a bit unclear. I think the automated tests need a "smoke test" at the least.
@raamana, perfect! I've set the archive DOI and updated the version number. The archive DOI is for the software release, whereas the JOSS DOI will be for the paper. (There are also different kinds of DOIs--DataCite vs. CrossRef--which have differences in how their associated metadata and how they are processed by services like Google Scholar and PubMed.)
@arfon, we're all set to accept here!