New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Multiphonon: Phonon Density of States tools for Inelastic Neutron Scattering Powder Data #422

Closed
whedon opened this Issue Oct 3, 2017 · 27 comments

Comments

Projects
None yet
7 participants
@whedon
Collaborator

whedon commented Oct 3, 2017

Submitting author: @yxqd (Jiao Lin)
Repository: https://github.com/sns-chops/multiphonon
Version: 0.1.1
Editor: @lheagy
Reviewer: @bjmorgan

Author instructions

Thanks for submitting your paper to JOSS @yxqd. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@yxqd if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Oct 3, 2017

Collaborator

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @lheagy it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands
Collaborator

whedon commented Oct 3, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @lheagy it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands
@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Oct 3, 2017

Member

👋 @lheagy - the submitting author suggested you as an editor.

Member

arfon commented Oct 3, 2017

👋 @lheagy - the submitting author suggested you as an editor.

@yxqd

This comment has been minimized.

Show comment
Hide comment
@yxqd

yxqd Oct 3, 2017

Collaborator

@arfon @lheagy May I suggest @tacaswell @nicoguaro or @bjmorgan as potential reviewers? Thanks.

Collaborator

yxqd commented Oct 3, 2017

@arfon @lheagy May I suggest @tacaswell @nicoguaro or @bjmorgan as potential reviewers? Thanks.

@nicoguaro

This comment has been minimized.

Show comment
Hide comment
@nicoguaro

nicoguaro Oct 4, 2017

Collaborator

I will have to turn this one down.

Collaborator

nicoguaro commented Oct 4, 2017

I will have to turn this one down.

@lheagy

This comment has been minimized.

Show comment
Hide comment
@lheagy

lheagy Oct 5, 2017

Member

Hi @arfon and @yxqd - I am travelling at the moment and then will be back into the swing of things on Monday. I will get back to you then. Thanks for your patience

Member

lheagy commented Oct 5, 2017

Hi @arfon and @yxqd - I am travelling at the moment and then will be back into the swing of things on Monday. I will get back to you then. Thanks for your patience

@lheagy

This comment has been minimized.

Show comment
Hide comment
@lheagy

lheagy Oct 10, 2017

Member

Condensed matter physics isn't really my background, but I am happy to work with this submission. @arfon, is there anyone else one the editorial board that you think might have more background in this that could support?

@yxqd, I have a couple questions / comments regarding the paper:

  • right now, the summary is brief and quite technical. I would recommend you expand it to make it more accessible for a broader audience. This could include some examples, or further discussion of applications.
  • regarding the notice of copyright in the paper. All JOSS papers are licensed under a Creative Commons Attribution 4.0 License (http://joss.theoj.org/about#content_license). This does not appear to be a conflict, but I wanted to clarify that with you cc @arfon: are there any concerns with such a statement in the paper
  • regarding testing, do you have coverage stats that could also be shown alongside the build status in the README? for example https://codecov.io/
Member

lheagy commented Oct 10, 2017

Condensed matter physics isn't really my background, but I am happy to work with this submission. @arfon, is there anyone else one the editorial board that you think might have more background in this that could support?

@yxqd, I have a couple questions / comments regarding the paper:

  • right now, the summary is brief and quite technical. I would recommend you expand it to make it more accessible for a broader audience. This could include some examples, or further discussion of applications.
  • regarding the notice of copyright in the paper. All JOSS papers are licensed under a Creative Commons Attribution 4.0 License (http://joss.theoj.org/about#content_license). This does not appear to be a conflict, but I wanted to clarify that with you cc @arfon: are there any concerns with such a statement in the paper
  • regarding testing, do you have coverage stats that could also be shown alongside the build status in the README? for example https://codecov.io/
@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Oct 10, 2017

Member
  • regarding the notice of copyright in the paper. All JOSS papers are licensed under a Creative Commons Attribution 4.0 License (http://joss.theoj.org/about#content_license). This does not appear to be a conflict, but I wanted to clarify that with you cc @arfon: are there any concerns with such a statement in the paper

Thanks for the heads up @lheagy - I don't think this copyright statement causes us any major issues.

Member

arfon commented Oct 10, 2017

  • regarding the notice of copyright in the paper. All JOSS papers are licensed under a Creative Commons Attribution 4.0 License (http://joss.theoj.org/about#content_license). This does not appear to be a conflict, but I wanted to clarify that with you cc @arfon: are there any concerns with such a statement in the paper

Thanks for the heads up @lheagy - I don't think this copyright statement causes us any major issues.

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Oct 10, 2017

Member

Condensed matter physics isn't really my background, but I am happy to work with this submission. @arfon, is there anyone else one the editorial board that you think might have more background in this that could support?

Not really sorry. This is pretty much out of the remit of most of our editors I think.

Member

arfon commented Oct 10, 2017

Condensed matter physics isn't really my background, but I am happy to work with this submission. @arfon, is there anyone else one the editorial board that you think might have more background in this that could support?

Not really sorry. This is pretty much out of the remit of most of our editors I think.

@yxqd

This comment has been minimized.

Show comment
Hide comment
@yxqd

yxqd Oct 10, 2017

Collaborator

@lheagy thanks! I admit I don't know enough about the editors backgrounds and did not find an editor specializing on condensed matter physics. You were the closest I could find from the editor list since studies on condensed matter in extreme conditions (high temperature and high pressure, for example) are topics of research in geophysics. Again, thanks @lheagy for picking this up.

@lheagy regarding your comments:

  • I agree more explanations should help clarify the applications of the software. I will revise the summary as you suggested
  • The notice of copyright was a standard text required by our lab. I don't think it is in conflict with Creative Commons. @arfon please let us know if there are problems
  • Tests are run by travis CI right now. I will try to get coverage stats as you suggested.

I am travelling this week so I will only be able to work on these revisions next week. I will keep you posted. @lheagy @arfon please kindly update me on the editing and the copyright text. Thanks!

Collaborator

yxqd commented Oct 10, 2017

@lheagy thanks! I admit I don't know enough about the editors backgrounds and did not find an editor specializing on condensed matter physics. You were the closest I could find from the editor list since studies on condensed matter in extreme conditions (high temperature and high pressure, for example) are topics of research in geophysics. Again, thanks @lheagy for picking this up.

@lheagy regarding your comments:

  • I agree more explanations should help clarify the applications of the software. I will revise the summary as you suggested
  • The notice of copyright was a standard text required by our lab. I don't think it is in conflict with Creative Commons. @arfon please let us know if there are problems
  • Tests are run by travis CI right now. I will try to get coverage stats as you suggested.

I am travelling this week so I will only be able to work on these revisions next week. I will keep you posted. @lheagy @arfon please kindly update me on the editing and the copyright text. Thanks!

@yxqd

This comment has been minimized.

Show comment
Hide comment
@yxqd

yxqd Oct 17, 2017

Collaborator

@lheagy could you please check the expanded summary in the revised paper? The coverage badge were added to the readme. Could you please find a reviewer for this paper? Thanks.

Collaborator

yxqd commented Oct 17, 2017

@lheagy could you please check the expanded summary in the revised paper? The coverage badge were added to the readme. Could you please find a reviewer for this paper? Thanks.

@lheagy

This comment has been minimized.

Show comment
Hide comment
@lheagy

lheagy Oct 18, 2017

Member

Thanks for the updates @yxqd!

Member

lheagy commented Oct 18, 2017

Thanks for the updates @yxqd!

@lheagy

This comment has been minimized.

Show comment
Hide comment
@lheagy

lheagy Oct 18, 2017

Member

👋 Hi @tacaswell and @bjmorgan, would you be willing to review this submission to JOSS?

Member

lheagy commented Oct 18, 2017

👋 Hi @tacaswell and @bjmorgan, would you be willing to review this submission to JOSS?

@yxqd

This comment has been minimized.

Show comment
Hide comment
@yxqd

yxqd Oct 19, 2017

Collaborator

Thanks @lheagy !

Collaborator

yxqd commented Oct 19, 2017

Thanks @lheagy !

@lheagy

This comment has been minimized.

Show comment
Hide comment
@lheagy

lheagy Oct 20, 2017

Member

@yxqd: I have sent emails to @tacaswell and @bjmorgan asking if they are willing to review. If we haven't heard back early next week, we can reach out to other reviewers.

Member

lheagy commented Oct 20, 2017

@yxqd: I have sent emails to @tacaswell and @bjmorgan asking if they are willing to review. If we haven't heard back early next week, we can reach out to other reviewers.

@yxqd

This comment has been minimized.

Show comment
Hide comment
@yxqd

yxqd Oct 20, 2017

Collaborator

May I suggest some other potential reviewers: @khinsen, @betatim, @jochym ?

Collaborator

yxqd commented Oct 20, 2017

May I suggest some other potential reviewers: @khinsen, @betatim, @jochym ?

@yxqd

This comment has been minimized.

Show comment
Hide comment
@yxqd

yxqd Oct 20, 2017

Collaborator

@lheagy Thanks!

Collaborator

yxqd commented Oct 20, 2017

@lheagy Thanks!

@bjmorgan

This comment has been minimized.

Show comment
Hide comment
@bjmorgan

bjmorgan Oct 21, 2017

Collaborator

@lheagy Happy to review.

Collaborator

bjmorgan commented Oct 21, 2017

@lheagy Happy to review.

@lheagy

This comment has been minimized.

Show comment
Hide comment
@lheagy

lheagy Oct 21, 2017

Member

Thanks @bjmorgan!

@tacaswell, @khinsen, @betatim, @jochym: would one of you be willing to be a second reviewer for this submission?

Member

lheagy commented Oct 21, 2017

Thanks @bjmorgan!

@tacaswell, @khinsen, @betatim, @jochym: would one of you be willing to be a second reviewer for this submission?

@yxqd

This comment has been minimized.

Show comment
Hide comment
@yxqd

yxqd Oct 22, 2017

Collaborator

Thank you @bjmorgan @lheagy !

Collaborator

yxqd commented Oct 22, 2017

Thank you @bjmorgan @lheagy !

@yxqd

This comment has been minimized.

Show comment
Hide comment
@yxqd

yxqd Oct 26, 2017

Collaborator

👋 @lheagy is second reviewer required?

Collaborator

yxqd commented Oct 26, 2017

👋 @lheagy is second reviewer required?

@lheagy

This comment has been minimized.

Show comment
Hide comment
@lheagy

lheagy Oct 26, 2017

Member

@yxqd, sorry for the delay. It is preferable to have multiple reviewers, and is important here, as I really don't have much background in condensed matter physics.

I have sent emails to @tacaswell, @betatim, @jochym (I couldn't find an email for @khinsen). If you know them personally and would also like to send an email, please feel free to point them to this issue. My email is lheagy@eos.ubc.ca if you would like to cc me.

Member

lheagy commented Oct 26, 2017

@yxqd, sorry for the delay. It is preferable to have multiple reviewers, and is important here, as I really don't have much background in condensed matter physics.

I have sent emails to @tacaswell, @betatim, @jochym (I couldn't find an email for @khinsen). If you know them personally and would also like to send an email, please feel free to point them to this issue. My email is lheagy@eos.ubc.ca if you would like to cc me.

@jochym

This comment has been minimized.

Show comment
Hide comment
@jochym

jochym Oct 27, 2017

Collaborator

@lheagy I'll be willing to review the paper. I do not have much of experience on experimental side but I have a background in phonon calculations - I am a theoretician. This would be my first paper at joss (I already know the http://joss.theoj.org/about#reviewer_guidelines ). What should be the next steps?

Collaborator

jochym commented Oct 27, 2017

@lheagy I'll be willing to review the paper. I do not have much of experience on experimental side but I have a background in phonon calculations - I am a theoretician. This would be my first paper at joss (I already know the http://joss.theoj.org/about#reviewer_guidelines ). What should be the next steps?

@lheagy

This comment has been minimized.

Show comment
Hide comment
@lheagy

lheagy Oct 27, 2017

Member

Thanks @bjmorgan and @jochym for agreeing to review! I will close this issue and we will start a new issue that includes a checklist for the review. There is only one checklist, so please feel free to communicate back and forth on the issue if there are items to discuss and please don't hesitate to let me know if you have questions. Only one person is listed as the reviewer at the moment (we are working on listing two), but I would very much appreciate input from both of you on the review.

Member

lheagy commented Oct 27, 2017

Thanks @bjmorgan and @jochym for agreeing to review! I will close this issue and we will start a new issue that includes a checklist for the review. There is only one checklist, so please feel free to communicate back and forth on the issue if there are items to discuss and please don't hesitate to let me know if you have questions. Only one person is listed as the reviewer at the moment (we are working on listing two), but I would very much appreciate input from both of you on the review.

@lheagy

This comment has been minimized.

Show comment
Hide comment
@lheagy

lheagy Oct 27, 2017

Member

@whedon assign @bjmorgan as reviewer

Member

lheagy commented Oct 27, 2017

@whedon assign @bjmorgan as reviewer

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Oct 27, 2017

Collaborator

OK, the reviewer is @bjmorgan

Collaborator

whedon commented Oct 27, 2017

OK, the reviewer is @bjmorgan

@lheagy

This comment has been minimized.

Show comment
Hide comment
@lheagy

lheagy Oct 27, 2017

Member

@whedon start review magic-word=bananas

Member

lheagy commented Oct 27, 2017

@whedon start review magic-word=bananas

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Oct 27, 2017

Collaborator

OK, I've started the review over in #440. Feel free to close this issue now!

Collaborator

whedon commented Oct 27, 2017

OK, I've started the review over in #440. Feel free to close this issue now!

@lheagy lheagy closed this Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment