New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: DynamicalBilliards.jl : An easy-to-use, modular and extendable Julia package for Dynamical Billiard systems in two dimensions. #442

Closed
whedon opened this Issue Oct 29, 2017 · 31 comments

Comments

Projects
None yet
7 participants
@whedon
Collaborator

whedon commented Oct 29, 2017

Submitting author: @Datseris (George Datserus)
Repository: https://github.com/JuliaDynamics/DynamicalBilliards.jl
Version: v1.6.1
Editor: @kyleniemeyer
Reviewer: @ahwillia

Author instructions

Thanks for submitting your paper to JOSS @Datseris. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@Datseris if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Oct 29, 2017

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Oct 29, 2017

Collaborator

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS.

For a list of things I can do to help you, just type:

@whedon commands
Collaborator

whedon commented Oct 29, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS.

For a list of things I can do to help you, just type:

@whedon commands
@Datseris

This comment has been minimized.

Show comment
Hide comment
@Datseris

Datseris commented Oct 29, 2017

@whedon commands

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Oct 29, 2017

Collaborator

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List the GitHub usernames of the JOSS editors
@whedon list editors

# List of JOSS reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 Important 🚧

This is all quite new. Please make sure you check the top of the issue after running a @whedon command (you might also need to refresh the page to see the issue update).

Collaborator

whedon commented Oct 29, 2017

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List the GitHub usernames of the JOSS editors
@whedon list editors

# List of JOSS reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 Important 🚧

This is all quite new. Please make sure you check the top of the issue after running a @whedon command (you might also need to refresh the page to see the issue update).

@Datseris

This comment has been minimized.

Show comment
Hide comment
@Datseris

Datseris Oct 29, 2017

@whedon list reviewers

Datseris commented Oct 29, 2017

@whedon list reviewers

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Oct 29, 2017

Collaborator

Here's the current list of JOSS reviewers: https://bit.ly/joss-reviewers

Collaborator

whedon commented Oct 29, 2017

Here's the current list of JOSS reviewers: https://bit.ly/joss-reviewers

@Datseris

This comment has been minimized.

Show comment
Hide comment
@Datseris

Datseris commented Oct 29, 2017

@whedon assign @ChrisRackauckas as reviewer

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Oct 29, 2017

Collaborator

I'm sorry @Datseris, I'm afraid I can't do that. That's something only JOSS editors are allowed to do.

Collaborator

whedon commented Oct 29, 2017

I'm sorry @Datseris, I'm afraid I can't do that. That's something only JOSS editors are allowed to do.

@Datseris

This comment has been minimized.

Show comment
Hide comment
@Datseris

Datseris Oct 29, 2017

Cool. So now I guess I just wait.

Datseris commented Oct 29, 2017

Cool. So now I guess I just wait.

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 14, 2017

Collaborator

I will handle this submission.

Collaborator

kyleniemeyer commented Nov 14, 2017

I will handle this submission.

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 14, 2017

Collaborator

@whedon assign @kyleniemeyer as editor

Collaborator

kyleniemeyer commented Nov 14, 2017

@whedon assign @kyleniemeyer as editor

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 14, 2017

Collaborator

OK, the editor is @kyleniemeyer

Collaborator

whedon commented Nov 14, 2017

OK, the editor is @kyleniemeyer

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 14, 2017

Collaborator

Hi @Datseris, sorry for the delay—without a suggested editor this fell through the cracks slightly.

Can you suggest one domain-specific reviewer for this package? I noticed that you tried to assign @ChrisRackauckas above, but then in your software README I can see that you acknowledged him as contributing to the code—that would be a conflict of interest, unfortunately. Someone that you had discussed the project with but hadn't actually contributed to the software would be more acceptable.

(and additional comments in the review issue from @ChrisRackauckas or whoever are still welcome, of course)

Collaborator

kyleniemeyer commented Nov 14, 2017

Hi @Datseris, sorry for the delay—without a suggested editor this fell through the cracks slightly.

Can you suggest one domain-specific reviewer for this package? I noticed that you tried to assign @ChrisRackauckas above, but then in your software README I can see that you acknowledged him as contributing to the code—that would be a conflict of interest, unfortunately. Someone that you had discussed the project with but hadn't actually contributed to the software would be more acceptable.

(and additional comments in the review issue from @ChrisRackauckas or whoever are still welcome, of course)

@Datseris

This comment has been minimized.

Show comment
Hide comment
@Datseris

Datseris Nov 14, 2017

Hello, thanks for finally getting into this, I appreciate it.

The following seem to have relation to the Physics area I am interested in:

mlxd
jarvist
ahwillia

but still the connection is not that big... I hope it will be okay.

P.S.: Could you tell me how I can also apply to become a reviewer? I searched the website but I could not find where the application is. Do I just put my name in the google spreadsheet?

Datseris commented Nov 14, 2017

Hello, thanks for finally getting into this, I appreciate it.

The following seem to have relation to the Physics area I am interested in:

mlxd
jarvist
ahwillia

but still the connection is not that big... I hope it will be okay.

P.S.: Could you tell me how I can also apply to become a reviewer? I searched the website but I could not find where the application is. Do I just put my name in the google spreadsheet?

@Datseris

This comment has been minimized.

Show comment
Hide comment
@Datseris

Datseris Nov 15, 2017

Should I tag these persons? I am not sure how things work here, sorry.

Datseris commented Nov 15, 2017

Should I tag these persons? I am not sure how things work here, sorry.

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 15, 2017

Collaborator

Hi @Datseris, I can take care of that—aside from the existing JOSS reviewers, is there anyone closer to your domain who you might recommend? (It's ok if not)

As for adding your name to the reviewer list, you can use this link: http://joss.theoj.org/reviewer-signup.html

Collaborator

kyleniemeyer commented Nov 15, 2017

Hi @Datseris, I can take care of that—aside from the existing JOSS reviewers, is there anyone closer to your domain who you might recommend? (It's ok if not)

As for adding your name to the reviewer list, you can use this link: http://joss.theoj.org/reviewer-signup.html

@ChrisRackauckas

This comment has been minimized.

Show comment
Hide comment
@ChrisRackauckas

ChrisRackauckas Nov 15, 2017

Collaborator

@ahwillia would be a good fit.

Collaborator

ChrisRackauckas commented Nov 15, 2017

@ahwillia would be a good fit.

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 15, 2017

Collaborator

@ChrisRackauckas thanks!

Hello @ahwillia @mlxd @jarvist @ahwillia, would you be willing to review this submission for JOSS? (I prefer to have at least two reviewers, but more are also welcome if you are interested!) Thanks!

Collaborator

kyleniemeyer commented Nov 15, 2017

@ChrisRackauckas thanks!

Hello @ahwillia @mlxd @jarvist @ahwillia, would you be willing to review this submission for JOSS? (I prefer to have at least two reviewers, but more are also welcome if you are interested!) Thanks!

@Datseris

This comment has been minimized.

Show comment
Hide comment
@Datseris

Datseris Nov 15, 2017

@kyleniemeyer unfortunately all the people that I can recommend have discussed with me the code in some way or another, therefore the conflict of interests would not go away...

Datseris commented Nov 15, 2017

@kyleniemeyer unfortunately all the people that I can recommend have discussed with me the code in some way or another, therefore the conflict of interests would not go away...

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 15, 2017

Collaborator

@Datseris that's all right, let's see if we can find someone else first. Having a discussion would not be a COI, just actually contributing to the code.

Collaborator

kyleniemeyer commented Nov 15, 2017

@Datseris that's all right, let's see if we can find someone else first. Having a discussion would not be a COI, just actually contributing to the code.

@ahwillia

This comment has been minimized.

Show comment
Hide comment
@ahwillia

ahwillia Nov 15, 2017

Collaborator

I'd be happy to review this.

Collaborator

ahwillia commented Nov 15, 2017

I'd be happy to review this.

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 15, 2017

Collaborator

@ahwillia thanks! I'll wait a bit longer to see if any of the others tagged are also willing to review, for a second opinion.

Collaborator

kyleniemeyer commented Nov 15, 2017

@ahwillia thanks! I'll wait a bit longer to see if any of the others tagged are also willing to review, for a second opinion.

@mlxd

This comment has been minimized.

Show comment
Hide comment
@mlxd

mlxd Nov 15, 2017

Collaborator

Also happy to review this.

Collaborator

mlxd commented Nov 15, 2017

Also happy to review this.

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 15, 2017

Collaborator

Excellent!

Collaborator

kyleniemeyer commented Nov 15, 2017

Excellent!

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 15, 2017

Collaborator

@whedon assign @ahwillia as reviewer

Collaborator

kyleniemeyer commented Nov 15, 2017

@whedon assign @ahwillia as reviewer

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 15, 2017

Collaborator

OK, the reviewer is @ahwillia

Collaborator

whedon commented Nov 15, 2017

OK, the reviewer is @ahwillia

@whedon whedon assigned ahwillia and kyleniemeyer and unassigned kyleniemeyer Nov 15, 2017

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 15, 2017

Collaborator

@whedon start review

Collaborator

kyleniemeyer commented Nov 15, 2017

@whedon start review

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 15, 2017

Collaborator

You didn't say the magic word! Try this:

@whedon start review magic-word=bananas
Collaborator

whedon commented Nov 15, 2017

You didn't say the magic word! Try this:

@whedon start review magic-word=bananas
@Datseris

This comment has been minimized.

Show comment
Hide comment
@Datseris

Datseris Nov 15, 2017

hahahahaha

Datseris commented Nov 15, 2017

hahahahaha

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 15, 2017

Collaborator

@whedon start review magic-word=bananas

Collaborator

kyleniemeyer commented Nov 15, 2017

@whedon start review magic-word=bananas

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 15, 2017

Collaborator

OK, I've started the review over in #458. Feel free to close this issue now!

Collaborator

whedon commented Nov 15, 2017

OK, I've started the review over in #458. Feel free to close this issue now!

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 15, 2017

Collaborator

Alright, @Datseris @ahwillia @mlxd we'll move over to #458 for the actual review.

Currently our infrastructure only "officially" supports one reviewer, so @ahwillia will be able to edit the checkboxes, but @mlxd please comment in the thread if you disagree with anything (along with your regular comments).

Collaborator

kyleniemeyer commented Nov 15, 2017

Alright, @Datseris @ahwillia @mlxd we'll move over to #458 for the actual review.

Currently our infrastructure only "officially" supports one reviewer, so @ahwillia will be able to edit the checkboxes, but @mlxd please comment in the thread if you disagree with anything (along with your regular comments).

@arfon arfon closed this Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment