[PRE REVIEW]: GlobalSensitivity.jl: julia package for performant global sensitivity analysis

[editorialbot]

Submitting author: @Vaibhavdixit02 (Vaibhav Dixit)
Repository: https://github.com/SciML/GlobalSensitivity.jl
Branch with paper.md (empty if default branch):
Version: v2.0.0
Editor: @jbytecode
Reviewers: @zhenwu0728, @storyetfall
Managing EiC: Kevin M. Moerman

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/aaa43a640c8764640c2a8cc30b7d9dec"><img src="https://joss.theoj.org/papers/aaa43a640c8764640c2a8cc30b7d9dec/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/aaa43a640c8764640c2a8cc30b7d9dec/status.svg)](https://joss.theoj.org/papers/aaa43a640c8764640c2a8cc30b7d9dec)

Author instructions

Thanks for submitting your paper to JOSS @Vaibhavdixit02. Currently, there isn't an JOSS editor assigned to your paper.

@Vaibhavdixit02 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (1544.4 files/s, 124764.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           22            280            118           1563
Markdown                        14            261              0            828
TeX                              1             26              0            428
YAML                             6              8              7            152
TOML                             3              5              0             40
-------------------------------------------------------------------------------
SUM:                            46            580            125           3011
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 1053

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.00097 is OK
- 10.1080/00949659708811825 is OK
- 10.1016/j.ress.2006.04.015 is OK
- 10.1016/j.envsoft.2006.10.004 is OK
- 10.2307/1269043 is OK
- 10.1016/j.ejor.2012.11.047 is OK
- 10.1016/S0010-4655(02)00280-1 is OK
- 10.1016/0167-9473(95)92843-M is OK
- 10.1080/00401706.1999.10485594 is OK
- 10.1016/j.envsoft.2010.04.012 is OK
- 10.1016/j.cpc.2009.09.018 is OK
- 10.1016/S0167-9473(97)00043-1 is OK
- 10.1021/cr040659d is OK
- 10.1002/9780470725184.ch4 is OK
- 10.1198/016214502388618447 is OK
- 10.1016/j.chemolab.2011.10.006 is OK
- 10.1016/j.matcom.2009.01.023 is OK
- 10.1016/S0378-4754(00)00270-6 is OK
- 10.1016/j.ress.2005.06.003 is OK
- 10.1016/j.cageo.2013.06.006 is OK
- 10.1007/978-3-319-41508-6_12 is OK
- 10.1137/141000671 is OK
- 10.21105/joss.03349 is OK

MISSING DOIs

- 10.1007/s11538-021-00982-5 may be a valid DOI for title: A Quantitative Systems Pharmacology perspective on the importance of parameter identifiability
- 10.1002/psp4.6 may be a valid DOI for title: Sobol sensitivity analysis: a tool to guide the development and evaluation of systems pharmacology models

INVALID DOIs

- https://doi.org/10.1016/j.ress.2009.11.005 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.envsoft.2012.03.004 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.envsoft.2006.01.004 is INVALID because of 'https://doi.org/' prefix

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[Kevin-Mattheus-Moerman]

@Vaibhavdixit02 @ChrisRackauckas Thanks for this submission to JOSS. I am an AEiC for JOSS and here to help process the initial steps. Below are some comments to work on before we proceed.

• Please check those potentially missing and invalid DOIs ☝️ you can update the paper by calling @editorialbot generate pdf and you can check the references again by calling @editorialbot check references.
• Please complete your affiliations to include city and country and do not use acronyms (e.g. spell our Massachusetts Institute of Technology, and Unites States of America), and if you'd like to add a department for an academic affiliation you can.
• Please extend your README to be more complete, i.e. have a short description/summary, provide information on documentation, installation, and getting started. In addition please add contributing guidelines. An example of a more complete one can be found here:
• https://github.com/gridap/Gridap.jl
• I found a poster discussing this work. The poster is fine, but can you comment on if this work has been published anywhere else?
• On the poster, it mentions an additional author Vijay Ivaturi, however this person is not listed on this JOSS submission. Can you confirm this is correct?
• Please can you add descriptive figure captions. Currently the captions appear to be short labels.
• The draft paper lacks an Acknowledgements section. This section is not a requirement but I am just pointing it out in case you'd like to add one.
• The paper mentions GlobalSensitivity.jl provides julia implementation of some of the popular GSA methods, can you clarify if it only implements existing algorithms or if any new functionality is made available here?
• Can you expand the Statement of Need section to include references to existing software which also implements/collects these GSA methods? E.g. what are the current "competitors" for this package, and how is this package different?
• Check part of modelling workflow this should perhaps read part of modelling workflows.
• Check provides Julia implementation, this should probably read provides a Julia implementation.
• The language name julia should feature a capital letter e.g. Julia throughout (also in the title).
• Should Regression (top of second page) be written regression?
• Check if gsa function should read GSA function

[ChrisRackauckas]

I found a poster discussing this work. The poster is fine, but can you comment on if this work has been published anywhere else?

No prior publication

On the poster, it mentions an additional author Vijay Ivaturi, however this person is not listed on this JOSS submission. Can you confirm this is correct?

This is correct.

gsa function should read GSA function

This should not because that would be a syntax error as functions in Julia need to respect capitalization. It's gsa function, so the gsa is highlighted as syntax rather than prose, and thus it should be matching capitalization.

[Kevin-Mattheus-Moerman]

@editorialbot invite @jbytecode as editor

[editorialbot]

Invitation to edit this submission sent!