Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: Retriever: Data Retrieval Tool #451
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
@amoeba, please carry out your review in this issue by updating the checklist below (please make sure you're logged in to GitHub). The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @leeper know.
Conflict of interest
Code of Conduct
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
Grade: 2) Minor revisions
I've had a chance to sit down and found this submission meets or exceeds the submission requirements on essentially every item on the reviewer checklist. It's clear to me what the software should do, it was easy for me to get the software installed and make use of it. On top of that, the documentation is abundant and well-written and it's clear a great deal of care has been put into many aspects of the project. I've checked all but one item off the list and am left with two outstanding issues:
@leeper can you please take a look at my two remaining issues and let me know what you think?
Regarding fit, this seems very much in line with other software published in JOSS. E.g.,
My group is a research lab and this software was built for our research and funded as research software by both NSF and the Moore Foundation.
@arfon I have been affiliated with the University of Florida. Could this affiliation be removed?
The submitted paper does not have this affiliation: https://raw.githubusercontent.com/weecology/retriever/master/paper/paper.md
OK thanks. I've re-generated the paper now too: https://github.com/openjournals/joss-papers/blob/8a8bb9cfd7d0d31ba84475e7708df7b4594413af/joss.00451/10.21105.joss.00451.pdf