New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ros_control: A generic and simple control framework for ROS #452

Closed
whedon opened this Issue Nov 10, 2017 · 23 comments

Comments

Projects
None yet
8 participants
@whedon
Collaborator

whedon commented Nov 10, 2017

Submitting author: @bmagyar (Bence Magyar)
Repository: https://github.com/ros-controls/joss_paper
Version: 0.12.0
Editor: @danielskatz
Reviewer: @progtologist

Author instructions

Thanks for submitting your paper to JOSS @bmagyar. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@bmagyar if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Nov 10, 2017

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 10, 2017

Collaborator

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS.

For a list of things I can do to help you, just type:

@whedon commands
Collaborator

whedon commented Nov 10, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS.

For a list of things I can do to help you, just type:

@whedon commands
@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Nov 10, 2017

Member

👋 @bmagyar. Thanks for your submission to JOSS. A couple of questions/clarifications on this submission:

  • Could you confirm what the research application of the ros-controls suite of software is?
  • I'm concerned about the amount of work any reviewer is going to have to do here to review this submission. We generally expect one repository per submission but this looks to be a collection of separate software repositories. Is there a 'main' repository that it might make more sense to submit?
Member

arfon commented Nov 10, 2017

👋 @bmagyar. Thanks for your submission to JOSS. A couple of questions/clarifications on this submission:

  • Could you confirm what the research application of the ros-controls suite of software is?
  • I'm concerned about the amount of work any reviewer is going to have to do here to review this submission. We generally expect one repository per submission but this looks to be a collection of separate software repositories. Is there a 'main' repository that it might make more sense to submit?
@bmagyar

This comment has been minimized.

Show comment
Hide comment
@bmagyar

bmagyar Nov 10, 2017

Collaborator

Hi @arfon

ros_control is a framework for robot control for robots using the Robot Operating System (ROS). ROS is core to most modern robotics research and it is making it's way to industry as well (e.g.: warehouse robots, home-care research platforms, commercial & research-grade self driving cars). The last section of our paper has a list of some research robots where ros_control is used to provide the control architecture & allows for researchers to create their custom controllers using the framework. This project is rather mature, hence the size and number of applications.

I was indeed a bit worried that the review may get a wee bit tricky...

We split the framework among different repositories to ease the binary release process as some packages such as message definitions and core libraries are changed less frequently than our off-the-shelf controllers. I don't think it'd make sense to assess only one part of it.

I can try to help by providing a more detailed guide with pointing out all sources of documentation, how to set things up on one's machine for a quick test and pointers to our continuous integration & test suite with Travis.

Collaborator

bmagyar commented Nov 10, 2017

Hi @arfon

ros_control is a framework for robot control for robots using the Robot Operating System (ROS). ROS is core to most modern robotics research and it is making it's way to industry as well (e.g.: warehouse robots, home-care research platforms, commercial & research-grade self driving cars). The last section of our paper has a list of some research robots where ros_control is used to provide the control architecture & allows for researchers to create their custom controllers using the framework. This project is rather mature, hence the size and number of applications.

I was indeed a bit worried that the review may get a wee bit tricky...

We split the framework among different repositories to ease the binary release process as some packages such as message definitions and core libraries are changed less frequently than our off-the-shelf controllers. I don't think it'd make sense to assess only one part of it.

I can try to help by providing a more detailed guide with pointing out all sources of documentation, how to set things up on one's machine for a quick test and pointers to our continuous integration & test suite with Travis.

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Nov 10, 2017

Member

We split the framework among different repositories to ease the binary release process as some packages such as message definitions and core libraries are changed less frequently than our off-the-shelf controllers. I don't think it'd make sense to assess only one part of it.

OK thanks @bmagyar.

I can try to help by providing a more detailed guide with pointing out all sources of documentation, how to set things up on one's machine for a quick test and pointers to our continuous integration & test suite with Travis.

Yes, I think that might be useful. Also, a forewarning: we might struggle a little to find an editor and reviewers for this submission as it's somewhat outside our 'regular' subject matter.

Member

arfon commented Nov 10, 2017

We split the framework among different repositories to ease the binary release process as some packages such as message definitions and core libraries are changed less frequently than our off-the-shelf controllers. I don't think it'd make sense to assess only one part of it.

OK thanks @bmagyar.

I can try to help by providing a more detailed guide with pointing out all sources of documentation, how to set things up on one's machine for a quick test and pointers to our continuous integration & test suite with Travis.

Yes, I think that might be useful. Also, a forewarning: we might struggle a little to find an editor and reviewers for this submission as it's somewhat outside our 'regular' subject matter.

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Nov 10, 2017

Collaborator

I'm a little familiar with ROS, and could act as editor, given good suggestions for reviewers.

Collaborator

danielskatz commented Nov 10, 2017

I'm a little familiar with ROS, and could act as editor, given good suggestions for reviewers.

@bmagyar

This comment has been minimized.

Show comment
Hide comment
@bmagyar

bmagyar Nov 11, 2017

Collaborator
Collaborator

bmagyar commented Nov 11, 2017

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Nov 11, 2017

Member

Am I allowed to suggest or does it have to come from the editors?

We'd welcome some names (and ideally GitHub handles) for some potential reviewers.

Member

arfon commented Nov 11, 2017

Am I allowed to suggest or does it have to come from the editors?

We'd welcome some names (and ideally GitHub handles) for some potential reviewers.

@kyleniemeyer

This comment has been minimized.

Show comment
Hide comment
@kyleniemeyer

kyleniemeyer Nov 14, 2017

Collaborator

I may be able to help with a reviewer or two—I have some robotics colleagues here at Oregon State who work closely with ROS.

Collaborator

kyleniemeyer commented Nov 14, 2017

I may be able to help with a reviewer or two—I have some robotics colleagues here at Oregon State who work closely with ROS.

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Nov 14, 2017

Collaborator

@bmagyar, please offer some suggestions (that don't have conflicts, of course)

Collaborator

danielskatz commented Nov 14, 2017

@bmagyar, please offer some suggestions (that don't have conflicts, of course)

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Nov 14, 2017

Collaborator

@whedon assign @danielskatz as editor

Collaborator

danielskatz commented Nov 14, 2017

@whedon assign @danielskatz as editor

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 14, 2017

Collaborator

OK, the editor is @danielskatz

Collaborator

whedon commented Nov 14, 2017

OK, the editor is @danielskatz

@bmagyar

This comment has been minimized.

Show comment
Hide comment
@bmagyar

bmagyar Nov 14, 2017

Collaborator

There are 3 more people on my list, waiting for confirmation of interest.

Collaborator

bmagyar commented Nov 14, 2017

There are 3 more people on my list, waiting for confirmation of interest.

@bmagyar

This comment has been minimized.

Show comment
Hide comment
@bmagyar

bmagyar Nov 14, 2017

Collaborator
  • Jorge Nicho (will be away but can either volunteer a colleague or review when back): works at Southwest Research Institute, they are part of the ROS-Industrial consortium | https://github.com/jrgnicho
Collaborator

bmagyar commented Nov 14, 2017

  • Jorge Nicho (will be away but can either volunteer a colleague or review when back): works at Southwest Research Institute, they are part of the ROS-Industrial consortium | https://github.com/jrgnicho
@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Nov 14, 2017

Collaborator

@j-rivero, @progtologist, @miguelprada - would you be willing to review this submission for JOSS?

Please see http://joss.theoj.org/about#reviewer_guidelines for reviewer guidelines.

Also, please be sure you do not have any conflict of interest.

Collaborator

danielskatz commented Nov 14, 2017

@j-rivero, @progtologist, @miguelprada - would you be willing to review this submission for JOSS?

Please see http://joss.theoj.org/about#reviewer_guidelines for reviewer guidelines.

Also, please be sure you do not have any conflict of interest.

@progtologist

This comment has been minimized.

Show comment
Hide comment
@progtologist

progtologist Nov 14, 2017

Collaborator

@danielskatz you can count me in

Collaborator

progtologist commented Nov 14, 2017

@danielskatz you can count me in

@miguelprada

This comment has been minimized.

Show comment
Hide comment
@miguelprada

miguelprada Nov 15, 2017

Collaborator

@danielskatz count me in too.

Collaborator

miguelprada commented Nov 15, 2017

@danielskatz count me in too.

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Nov 15, 2017

Collaborator

Thanks @progtologist and @miguelprada
I'll set up the review and get back to you shortly.

Collaborator

danielskatz commented Nov 15, 2017

Thanks @progtologist and @miguelprada
I'll set up the review and get back to you shortly.

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Nov 15, 2017

Collaborator

@whedon assign @progtologist as reviewer

Collaborator

danielskatz commented Nov 15, 2017

@whedon assign @progtologist as reviewer

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 15, 2017

Collaborator

OK, the reviewer is @progtologist

Collaborator

whedon commented Nov 15, 2017

OK, the reviewer is @progtologist

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Nov 15, 2017

Collaborator

@whedon start review magic-word=bananas

Collaborator

danielskatz commented Nov 15, 2017

@whedon start review magic-word=bananas

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 15, 2017

Collaborator

OK, I've started the review over in #456. Feel free to close this issue now!

Collaborator

whedon commented Nov 15, 2017

OK, I've started the review over in #456. Feel free to close this issue now!

@j-rivero

This comment has been minimized.

Show comment
Hide comment
@j-rivero

j-rivero Nov 17, 2017

@j-rivero, @progtologist, @miguelprada - would you be willing to review this submission for JOSS?

Sorry for not answering before, I'm happy to help if you sill need someone to perform a review.

j-rivero commented Nov 17, 2017

@j-rivero, @progtologist, @miguelprada - would you be willing to review this submission for JOSS?

Sorry for not answering before, I'm happy to help if you sill need someone to perform a review.

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Nov 17, 2017

Collaborator

@j-rivero - that's ok - we have enough reviewers now.

Collaborator

danielskatz commented Nov 17, 2017

@j-rivero - that's ok - we have enough reviewers now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment