New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: codemetar: Generate CodeMeta Metadata for R Packages #454

Closed
whedon opened this Issue Nov 12, 2017 · 10 comments

Comments

Projects
None yet
3 participants
@whedon
Collaborator

whedon commented Nov 12, 2017

Submitting author: @cboettig (Carl Boettiger)
Repository: https://github.com/ropensci/codemetar
Version: v0.1.1
Editor: @arfon
Reviewer: @arfon
Archive: 10.5281/zenodo.1048320

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/b16b968425f513da31632b0edd8ff0c5"><img src="http://joss.theoj.org/papers/b16b968425f513da31632b0edd8ff0c5/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/b16b968425f513da31632b0edd8ff0c5/status.svg)](http://joss.theoj.org/papers/b16b968425f513da31632b0edd8ff0c5)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer questions

@arfon, please carry out your review in this issue by updating the checklist below (please make sure you're logged in to GitHub). The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arfon know.

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: Does the release version given match the GitHub release (v0.1.1)?
  • Authorship: Has the submitting author (@cboettig) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 12, 2017

Collaborator

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @arfon it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
Collaborator

whedon commented Nov 12, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @arfon it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Nov 12, 2017

Member

Accepting because of onboarding into rOpenSci here: ropensci/onboarding#130

Member

arfon commented Nov 12, 2017

Accepting because of onboarding into rOpenSci here: ropensci/onboarding#130

@arfon arfon added the accepted label Nov 12, 2017

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Nov 12, 2017

Member

@cboettig - could you please merge this PR ropensci/codemetar#39 and once you've made those changes could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.

Member

arfon commented Nov 12, 2017

@cboettig - could you please merge this PR ropensci/codemetar#39 and once you've made those changes could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.

@cboettig

This comment has been minimized.

Show comment
Hide comment
@cboettig

cboettig Nov 13, 2017

@arfon Thanks, merged an paper.bib added for the links. Just lemme know if that all looks good and I'll create the release to get the new DOI.

cboettig commented Nov 13, 2017

@arfon Thanks, merged an paper.bib added for the links. Just lemme know if that all looks good and I'll create the release to get the new DOI.

@cboettig

This comment has been minimized.

Show comment
Hide comment
@cboettig

cboettig Nov 13, 2017

@arfon Okay, release made, DOI is: 10.5281/zenodo.1048320

cboettig commented Nov 13, 2017

@arfon Okay, release made, DOI is: 10.5281/zenodo.1048320

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Nov 13, 2017

Member

@whedon set 10.5281/zenodo.1048320 as archive

Member

arfon commented Nov 13, 2017

@whedon set 10.5281/zenodo.1048320 as archive

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 13, 2017

Collaborator

OK. 10.5281/zenodo.1048320 is the archive.

Collaborator

whedon commented Nov 13, 2017

OK. 10.5281/zenodo.1048320 is the archive.

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Nov 13, 2017

Member

@cboettig - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00454 ⚡️ 🚀 💥

Member

arfon commented Nov 13, 2017

@cboettig - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00454 ⚡️ 🚀 💥

@arfon arfon closed this Nov 13, 2017

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Nov 13, 2017

Member

Also, @cboettig - please merge this too when you get a chance ropensci/codemetar#40

Member

arfon commented Nov 13, 2017

Also, @cboettig - please merge this too when you get a chance ropensci/codemetar#40

@cboettig

This comment has been minimized.

Show comment
Hide comment
@cboettig

cboettig Nov 13, 2017

ok, merged, thanks!

cboettig commented Nov 13, 2017

ok, merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment