Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: simpleCache: R caching for reproducible, distributed, large-scale projects #463
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@sckott, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
Conflict of interest
Code of Conduct
referenced this issue
Nov 16, 2017
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
Nice work @vpnagraj et al. I have a few comments, with linked issues in your GH repo as applicable
Thanks for the feedback. We've now released version 0.4, which we think addresses all your comments. Thanks for the review!
To respond to one point here:
We recommend users use the functions to set the options, because these are easier to maintain and change. In a sense, the functions (which are documented) provide a contract with the user; we will honor those functions in the future. The actual option names, and the implementation of how they work, could change at some point, but the functions will remain the same. So, we'd rather just abstract away the actual implementation (whether it uses options, env vars, etc), so that we have room to adjust this as simpleCache advances, without breaking old code. We tried to make this clear with the documentation that explains these setter functions.
If you would like to include a link to your paper from your README use the following code snippet:
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider volunteering to review for us sometime in the future. You can add your name to the reviewer list here: http://joss.theoj.org/reviewer-signup.html