Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: An easy-to-use p5.js 3D object picker for visual artists #475
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@Fil, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
Conflict of interest
Code of Conduct
referenced this issue
Nov 30, 2017
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
Hello David (@physicsdavid)
After a first look at the requirements, a few of them are found insufficient:
I might be wrong on some of these issues, please don't hesitate to say it. And I will review again when they are fixed.
Though I'm not a p5 user myself (yet), it looks like the use case is indeed invaluable, and worth working to have this paper published in JOSS.
Thanks, Philippe (@Fil). These are very helpful comments. I believe I have addressed your issues with the following notes:
Feel free to ask for further revisions. Thanks again.
Thank you @physicsdavid for all the changes. They do indeed address all the issues!
(The only caveat is I'm not sure I understand why you have made a zip file of the example — it looked more directly accessible and readable as plain files one could look up on github or open in a browser. But it's not an issue for this review.)
@arfon my review is complete and positive for publication.
One of the common ways to distribute p5.js applications is via a zip file that contains the set of index.html, sketch.js, plus other assets as required. If you develop a sketch in the online editor (as many of my students do, for example), then if you want to download the sketch, you get a pre-packaged zip with everything in the right folder structure, etc. It's certainly not necessary and I could change it back. One other advantage is that many artists beginning to work with code won't be particularly familiar with github and will likely find it easier to just download one zip file with the example than deal with the files separately. But I'm open to whichever option seems better!
@physicsdavid - At this point could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission.