New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: CoreRobotics: An object-oriented C++ library with cross-language wrappers for cross-platform robot control #477

Closed
whedon opened this Issue Nov 30, 2017 · 25 comments

Comments

Projects
None yet
7 participants
@whedon
Collaborator

whedon commented Nov 30, 2017

Submitting author: @CoreRobotics (Parker Owan)
Repository: CoreRobotics/CoreRobotics
Version: v0.9.1
Editor: @danielskatz
Reviewer: @bmagyar

Author instructions

Thanks for submitting your paper to JOSS @CoreRobotics. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@CoreRobotics if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Nov 30, 2017

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 30, 2017

Collaborator

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands
Collaborator

whedon commented Nov 30, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 30, 2017

Collaborator
Attempting PDF compilation. Reticulating splines etc...
Collaborator

whedon commented Nov 30, 2017

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 30, 2017

Collaborator
PDF failed to compile for issue #477 with the following error: 

 Can't find any papers to compile :-(

Collaborator

whedon commented Nov 30, 2017

PDF failed to compile for issue #477 with the following error: 

 Can't find any papers to compile :-(

@CoreRobotics

This comment has been minimized.

Show comment
Hide comment
@CoreRobotics

CoreRobotics commented Nov 30, 2017

@whedon commands

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Nov 30, 2017

Collaborator

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper
@whedon generate pdf

Collaborator

whedon commented Nov 30, 2017

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper
@whedon generate pdf

@CoreRobotics

This comment has been minimized.

Show comment
Hide comment
@CoreRobotics

CoreRobotics Nov 30, 2017

Hello,

I believe the repository link of the original submission is broken. The repository is maintained at gitlab, however a mirror is on Github. The repository for this review needs to be updated to this link: https://github.com/CoreRobotics/CoreRobotics

From the list, @mosteo seems to be an appropriate reviewer. @jordigh as well.

CoreRobotics commented Nov 30, 2017

Hello,

I believe the repository link of the original submission is broken. The repository is maintained at gitlab, however a mirror is on Github. The repository for this review needs to be updated to this link: https://github.com/CoreRobotics/CoreRobotics

From the list, @mosteo seems to be an appropriate reviewer. @jordigh as well.

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Dec 1, 2017

Member

I believe the repository link of the original submission is broken. The repository is maintained at gitlab, however a mirror is on Github. The repository for this review needs to be updated to this link: https://github.com/CoreRobotics/CoreRobotics

Thanks for spotting this. It's now fixed in this review issue.

From the list, @mosteo seems to be an appropriate reviewer. @jordigh as well.

Thanks for the suggestions. We'll need an editor to assign themselves first before we can get going with the reviewers.

Member

arfon commented Dec 1, 2017

I believe the repository link of the original submission is broken. The repository is maintained at gitlab, however a mirror is on Github. The repository for this review needs to be updated to this link: https://github.com/CoreRobotics/CoreRobotics

Thanks for spotting this. It's now fixed in this review issue.

From the list, @mosteo seems to be an appropriate reviewer. @jordigh as well.

Thanks for the suggestions. We'll need an editor to assign themselves first before we can get going with the reviewers.

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Dec 1, 2017

Collaborator

@whedon assign @danielskatz as editor

Collaborator

danielskatz commented Dec 1, 2017

@whedon assign @danielskatz as editor

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Dec 1, 2017

Collaborator

OK, the editor is @danielskatz

Collaborator

whedon commented Dec 1, 2017

OK, the editor is @danielskatz

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Dec 1, 2017

Collaborator

I'll take this, and will start things later today or tomorrow

Collaborator

danielskatz commented Dec 1, 2017

I'll take this, and will start things later today or tomorrow

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Dec 1, 2017

Collaborator

@bmagyar - would you be willing to be on the other side of a JOSS paper and do a review?

@mosteo and @jordigh - would one of you be willing to review this as well?

See http://joss.theoj.org/about#reviewer_guidelines for JOSS reviewer guidelines.

Collaborator

danielskatz commented Dec 1, 2017

@bmagyar - would you be willing to be on the other side of a JOSS paper and do a review?

@mosteo and @jordigh - would one of you be willing to review this as well?

See http://joss.theoj.org/about#reviewer_guidelines for JOSS reviewer guidelines.

@bmagyar

This comment has been minimized.

Show comment
Hide comment
@bmagyar

bmagyar Dec 1, 2017

Collaborator

@danielskatz Sure, no problem. Assign it to me

Collaborator

bmagyar commented Dec 1, 2017

@danielskatz Sure, no problem. Assign it to me

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Dec 1, 2017

Collaborator

I will do so, and I will start the review once I get another reviewer, so there's no action for you at this point.

Collaborator

danielskatz commented Dec 1, 2017

I will do so, and I will start the review once I get another reviewer, so there's no action for you at this point.

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Dec 1, 2017

Collaborator

@whedon assign @bmagyar as reviewer

Collaborator

danielskatz commented Dec 1, 2017

@whedon assign @bmagyar as reviewer

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Dec 1, 2017

Collaborator

OK, the reviewer is @bmagyar

Collaborator

whedon commented Dec 1, 2017

OK, the reviewer is @bmagyar

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Dec 5, 2017

Collaborator

@CoreRobotics - Do you have any other reviewer suggestions? Such as someone else in the robotics community who knows software and is not conflicted with your or your co-authors, but perhaps isn't yet involved with JOSS? I would like to find a second reviewer.

Collaborator

danielskatz commented Dec 5, 2017

@CoreRobotics - Do you have any other reviewer suggestions? Such as someone else in the robotics community who knows software and is not conflicted with your or your co-authors, but perhaps isn't yet involved with JOSS? I would like to find a second reviewer.

@CoreRobotics

This comment has been minimized.

Show comment
Hide comment
@CoreRobotics

CoreRobotics Dec 6, 2017

@danielskatz - Hi Daniel, I'll ask around to see if I can find someone not in conflict. - Parker

CoreRobotics commented Dec 6, 2017

@danielskatz - Hi Daniel, I'll ask around to see if I can find someone not in conflict. - Parker

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Dec 7, 2017

Member

@amjaeger17 is this your cup of tea? Are you able to review this?

Member

Kevin-Mattheus-Moerman commented Dec 7, 2017

@amjaeger17 is this your cup of tea? Are you able to review this?

@amjaeger17

This comment has been minimized.

Show comment
Hide comment
@amjaeger17

amjaeger17 Dec 7, 2017

Collaborator

Hi,
Yeah, I am interested, and can definetly help check off some of the boxes.

Collaborator

amjaeger17 commented Dec 7, 2017

Hi,
Yeah, I am interested, and can definetly help check off some of the boxes.

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Dec 7, 2017

Collaborator

Thanks @amjaeger17 - I'll start the review in a few minutes

Collaborator

danielskatz commented Dec 7, 2017

Thanks @amjaeger17 - I'll start the review in a few minutes

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Dec 7, 2017

Collaborator

@whedon start review magic-word=bananas

Collaborator

danielskatz commented Dec 7, 2017

@whedon start review magic-word=bananas

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Dec 7, 2017

Collaborator

OK, I've started the review over in #489. Feel free to close this issue now!

Collaborator

whedon commented Dec 7, 2017

OK, I've started the review over in #489. Feel free to close this issue now!

@danielskatz danielskatz closed this Dec 7, 2017

@CoreRobotics

This comment has been minimized.

Show comment
Hide comment
@CoreRobotics

CoreRobotics Jan 4, 2018

generate pdf

CoreRobotics commented Jan 4, 2018

generate pdf

@danielskatz

This comment has been minimized.

Show comment
Hide comment
@danielskatz

danielskatz Jan 4, 2018

Collaborator

@CoreRobotics - this issue is closed - the review is going on in #489

Collaborator

danielskatz commented Jan 4, 2018

@CoreRobotics - this issue is closed - the review is going on in #489

@CoreRobotics

This comment has been minimized.

Show comment
Hide comment
@CoreRobotics

CoreRobotics Jan 4, 2018

Ok thanks - I didn't realize I could update the pdf in the new thread.

CoreRobotics commented Jan 4, 2018

Ok thanks - I didn't realize I could update the pdf in the new thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment