-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: MParT: Monotone Parameterization Toolkit #4843
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@ansgarwenzel, @f-t-s how is your review going? |
Review checklist for @f-t-sConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I worked my way through the checklist. I think this is a cool piece of software that will definitely be useful to my group's research. Do you need anything else from me for the review? |
No thanks. That was quick. Good luck with your new collaboration. |
Hi @ansgarwenzel please let us know how your review is going? |
Hi @ansgarwenzel please let us know how your review is going? |
Hi Patrick,
I was a bit sick the last two weeks.
I reviewed the latest version now, no more changes required from my side.
Kind regards,
Ansgar
Patrick Diehl ***@***.***> schrieb am Fr., 18. Nov. 2022,
18:37:
… Hi @ansgarwenzel <https://github.com/ansgarwenzel> please let us know how
your review is going?
—
Reply to this email directly, view it on GitHub
<#4843 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2HXBSRHYVDU7GPD5RDI3TWI65GDANCNFSM6AAAAAARCLXXDU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@editorialbot commands |
Hello @diehlpk, here are the things you can ask me to do:
|
@ansgarwenzel Can you please post |
@editorialbot generate my checklist |
Review checklist for @ansgarwenzelConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot check references |
@editorialbot generate paper |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
@editorialbot generate pdf |
Done! version is now v1.3.0 |
@editorialbot set 10.5281/zenodo.7435142 as archive |
Done! Archive is now 10.5281/zenodo.7435142 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3806, then you can now move forward with accepting the submission by compiling again with the command |
@mparno, just checking your paper here. The following sentence reads weirdly:
Is |
@arfon Yikes! How did that slip through? You're correct, "pronounced" should be removed. Would you like me to update the paper in our repo? |
@mparno Yes, please update the paper. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3842, then you can now move forward with accepting the submission by compiling again with the command |
I've reviewed the final proof and everything looks good on my end. |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@diehlpk @arfon @ansgarwenzel @f-t-s Thank you all! |
@ansgarwenzel, @f-t-s – many thanks for your reviews here and to @diehlpk for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @mparno – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @mparno (Matthew Parno)
Repository: https://github.com/MeasureTransport/MParT
Branch with paper.md (empty if default branch):
Version: v1.3.0
Editor: @diehlpk
Reviewers: @ansgarwenzel, @f-t-s
Archive: 10.5281/zenodo.7435142
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@ansgarwenzel & @f-t-s, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @diehlpk know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @f-t-s
📝 Checklist for @ansgarwenzel
The text was updated successfully, but these errors were encountered: