Join GitHub today
[REVIEW]: kima: Exoplanet detection in radial velocities #487
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@barentsen, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
Conflict of interest
Code of Conduct
referenced this issue
Dec 6, 2017
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
This was referenced
Dec 24, 2017
I am opening a few issues on the repository now because I happen to have spare time, but, needless to say: I do not expect a quick reply! @j-faria please enjoy your holidays and don't let my activity trigger you to work over the xmas-nye period, we all need time off to preserve mental health! =)
This was referenced
Dec 25, 2017
I installed and ran
I do think astronomy would benefit from having a high-quality open source software tool which contains the features and ideas provided by
Hi @barentsen, thank you for your thorough and very helpful review of
I sincerely appreciate your message about work during the holiday period. For a PhD student like me, such a balance is an important and often forgotten skill that needs mastering, so it's nice to see it highlighted.
First of all, I apologize for taking so long in submitting my review; a lot has happened in the past few months and finding time to throughly go through the code and documentation was very hard. However, after running the examples, going through the documentation and most of the code, I can now (at last!) write my review.
Let me start the review by saying congratulations on putting this software together! It is definitely work that is going to be very useful for many people working on the area of planet detection and characterization. It is also very timely given the advent of new radial-velocity follow-up machines.
As the authors can see, I have marked most of the review points above as I think they comply with the standards of a JOSS publication. I think the documentation is very good, and details quite nicely what the code does and how it does it. However, although the code runs smoothly, I found the examples to be not as thoroughly explained as I would like, thinking as a new user that wants to use the code for the things the code is supposed to do. In what follows, I will outline why I haven't marked the points above and what I would like to see in order to mark them as "done":
I have not marked the Version review point, as the repository still doesn't have a release (I suppose because it is awaiting for review).
Hi @nespinoza, thank you very much for the thorough review, I really appreciate it.
I agree completely with the three main points you raised as still missing. In the last couple of days I started addressing point 3, by creating issue and pull request templates, adding a
To address point 2, I was planning to create a tutorial / getting started guide as you suggested. This is (in some form) already included in the wiki but the points you identified are indeed missing.
Point 1 is harder to address completely. Actually, there is already the possibility to plot a set of posterior realizations of the model over the RV measurements. It is currently undocumented though, so it's as good as not being there. But I will solve that very soon.
I will work on a complete answer to the points raised in your review in the upcoming two weeks.
Thank you again!
referenced this issue
Jun 12, 2018
Hopefully these changes make the package ready for publication.
Regarding the Version and the github release, I think I'll need @arfon's help on this.
Thank you very much for considering the points made in the review. I have gone through all of them, including running the 51 Peg example, and everything runs smoothly!
I have no more comments to give; I think the software is in its final form in terms of a JOSS publication and, @arfon, @j-faria, I'm happy to recommend
Before finishing the review, one (optional, of course, as I have already recommended the software for publication) suggestion for @j-faria on
All the best,
If you would like to include a link to your paper from your README use the following code snippet:
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: