New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: tidyhydat: Extract and Tidy Canadian Hydrometric Data #511

Closed
whedon opened this Issue Dec 15, 2017 · 14 comments

Comments

Projects
None yet
4 participants
@whedon
Collaborator

whedon commented Dec 15, 2017

Submitting author: @boshek (Samuel Albers)
Repository: https://github.com/ropensci/tidyhydat
Version: 0.3.0
Editor: @arfon
Reviewer: @arfon
Archive: 10.5281/zenodo.1116459

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8fc1d00db51c3015ad49ab35b622423c"><img src="https://joss.theoj.org/papers/8fc1d00db51c3015ad49ab35b622423c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8fc1d00db51c3015ad49ab35b622423c/status.svg)](https://joss.theoj.org/papers/8fc1d00db51c3015ad49ab35b622423c)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@arfon, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arfon know.

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: Does the release version given match the GitHub release (0.3.0)?
  • Authorship: Has the submitting author (@boshek) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Dec 15, 2017

Collaborator

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @arfon it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
Collaborator

whedon commented Dec 15, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @arfon it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Dec 15, 2017

Collaborator
Attempting PDF compilation. Reticulating splines etc...
Collaborator

whedon commented Dec 15, 2017

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Dec 15, 2017

Collaborator
PDF failed to compile for issue #511 with the following error: 

   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    16  100    16    0     0     65      0 --:--:-- --:--:-- --:--:--    65
Error producing PDF.
! LaTeX Error: File `fancyvrb.sty' not found.

Type X to quit or <RETURN> to proceed,
or enter new name. (Default extension: sty)

Enter file name: 
! Emergency stop.
<read *> 
         
l.153 \newcommand

Looks like we failed to compile the PDF

Collaborator

whedon commented Dec 15, 2017

PDF failed to compile for issue #511 with the following error: 

   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    16  100    16    0     0     65      0 --:--:-- --:--:-- --:--:--    65
Error producing PDF.
! LaTeX Error: File `fancyvrb.sty' not found.

Type X to quit or <RETURN> to proceed,
or enter new name. (Default extension: sty)

Enter file name: 
! Emergency stop.
<read *> 
         
l.153 \newcommand

Looks like we failed to compile the PDF

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Dec 15, 2017

Member

Accepting because of rOpenSci acceptance in ropensci/tidyhydat#69

Member

arfon commented Dec 15, 2017

Accepting because of rOpenSci acceptance in ropensci/tidyhydat#69

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Dec 15, 2017

Member

@boshek - one more set of small changes ropensci/tidyhydat#70

Member

arfon commented Dec 15, 2017

@boshek - one more set of small changes ropensci/tidyhydat#70

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Dec 15, 2017

Member

@whedon set 10.5281/zenodo.1116459 as archive

Member

arfon commented Dec 15, 2017

@whedon set 10.5281/zenodo.1116459 as archive

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Dec 15, 2017

Collaborator

OK. 10.5281/zenodo.1116459 is the archive.

Collaborator

whedon commented Dec 15, 2017

OK. 10.5281/zenodo.1116459 is the archive.

@boshek

This comment has been minimized.

Show comment
Hide comment
@boshek

boshek Dec 15, 2017

Collaborator

@arfon Merged

Collaborator

boshek commented Dec 15, 2017

@arfon Merged

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Dec 15, 2017

Member

@boshek your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00511 ⚡️ 🚀 💥

Member

arfon commented Dec 15, 2017

@boshek your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00511 ⚡️ 🚀 💥

@arfon arfon closed this Dec 15, 2017

@arfon arfon added the accepted label Dec 15, 2017

@arfon arfon reopened this Dec 15, 2017

@arfon arfon closed this Dec 15, 2017

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Dec 15, 2017

Collaborator

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippet:

[![DOI](http://joss.theoj.org/papers/10.21105/joss.00511/status.svg)](https://doi.org/10.21105/joss.00511)

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://bit.ly/joss-reviewers

Collaborator

whedon commented Dec 15, 2017

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippet:

[![DOI](http://joss.theoj.org/papers/10.21105/joss.00511/status.svg)](https://doi.org/10.21105/joss.00511)

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://bit.ly/joss-reviewers

@boshek

This comment has been minimized.

Show comment
Hide comment
@boshek

boshek Jan 22, 2018

Collaborator

@arfon Embarrassing ask: Is there any opportunity to correct a few spelling errors in the article?

Collaborator

boshek commented Jan 22, 2018

@arfon Embarrassing ask: Is there any opportunity to correct a few spelling errors in the article?

@arfonsmith

This comment has been minimized.

Show comment
Hide comment
@arfonsmith

arfonsmith Jan 22, 2018

Collaborator
Collaborator

arfonsmith commented Jan 22, 2018

@boshek

This comment has been minimized.

Show comment
Hide comment
@boshek
Collaborator

boshek commented Jan 24, 2018

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Jan 24, 2018

Member

@boshek - this should be updated now.

Member

arfon commented Jan 24, 2018

@boshek - this should be updated now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment