New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: grapherator: A Modular Multi-Step Graph Generator #528

Closed
whedon opened this Issue Jan 8, 2018 · 24 comments

Comments

Projects
None yet
5 participants
@whedon
Collaborator

whedon commented Jan 8, 2018

Submitting author: @jakobbossek (Jakob Bossek)
Repository: https://github.com/jakobbossek/grapherator
Version: v1.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewer: @gvegayon
Archive: 10.5281/zenodo.1175943

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/c6c9ef032a807aa223b3975891728e45"><img src="http://joss.theoj.org/papers/c6c9ef032a807aa223b3975891728e45/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/c6c9ef032a807aa223b3975891728e45/status.svg)](http://joss.theoj.org/papers/c6c9ef032a807aa223b3975891728e45)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@gvegayon, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @Kevin-Mattheus-Moerman know.

Conflict of interest

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: Does the release version given match the GitHub release (v1.0.0)?
  • Authorship: Has the submitting author (@jakobbossek) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Jan 8, 2018

Collaborator

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @gvegayon it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
Collaborator

whedon commented Jan 8, 2018

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @gvegayon it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐️ Important ⭐️

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Jan 8, 2018

Collaborator
Attempting PDF compilation. Reticulating splines etc...
Collaborator

whedon commented Jan 8, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Jan 8, 2018

Collaborator
https://github.com/openjournals/joss-papers/blob/joss.00528/joss.00528/10.21105.joss.00528.pdf
Collaborator

whedon commented Jan 8, 2018

https://github.com/openjournals/joss-papers/blob/joss.00528/joss.00528/10.21105.joss.00528.pdf
@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Jan 8, 2018

Member

@jakobbossek @gvegayon review has started here. Let me know if I can help.

Member

Kevin-Mattheus-Moerman commented Jan 8, 2018

@jakobbossek @gvegayon review has started here. Let me know if I can help.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Feb 5, 2018

Member

@gvegayon @jakobbossek how are things going? Could you give an update on where things stand?

Member

Kevin-Mattheus-Moerman commented Feb 5, 2018

@gvegayon @jakobbossek how are things going? Could you give an update on where things stand?

@gvegayon

This comment has been minimized.

Show comment
Hide comment
@gvegayon

gvegayon Feb 5, 2018

Collaborator

Everything OK, just a bit busy these days. Will get back to @jakobbossek soon.

Collaborator

gvegayon commented Feb 5, 2018

Everything OK, just a bit busy these days. Will get back to @jakobbossek soon.

@gvegayon

This comment has been minimized.

Show comment
Hide comment
@gvegayon

gvegayon Feb 5, 2018

Collaborator

Looks good in general. Now I'll take a look at the documentation and code.

Collaborator

gvegayon commented Feb 5, 2018

Looks good in general. Now I'll take a look at the documentation and code.

@gvegayon gvegayon referenced this issue Feb 12, 2018

Closed

Review for JOSS #27

3 of 3 tasks complete
@gvegayon

This comment has been minimized.

Show comment
Hide comment
@gvegayon

gvegayon Feb 15, 2018

Collaborator

@Kevin-Mattheus-Moerman @jakobbossek everything looks good to me. I'm OK with the current state of the package.

Collaborator

gvegayon commented Feb 15, 2018

@Kevin-Mattheus-Moerman @jakobbossek everything looks good to me. I'm OK with the current state of the package.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman
Member

Kevin-Mattheus-Moerman commented Feb 19, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Feb 19, 2018

Collaborator
Attempting PDF compilation. Reticulating splines etc...
Collaborator

whedon commented Feb 19, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon
Collaborator

whedon commented Feb 19, 2018

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Feb 19, 2018

Member

@jakobbossek it looks like we are nearly there. Can you check your references for DOI's. Not all currently have DOI's, perhaps they are not available for all but please check.

Check your figure caption it says: "Each the graph topology and a scatterplot of...."

Member

Kevin-Mattheus-Moerman commented Feb 19, 2018

@jakobbossek it looks like we are nearly there. Can you check your references for DOI's. Not all currently have DOI's, perhaps they are not available for all but please check.

Check your figure caption it says: "Each the graph topology and a scatterplot of...."

@jakobbossek

This comment has been minimized.

Show comment
Hide comment
@jakobbossek

jakobbossek Feb 19, 2018

@Kevin-Mattheus-Moerman I tried hard to figure out DOI's for all the cited papers. Unfortuenately there are no DOI's available for most of them.

jakobbossek commented Feb 19, 2018

@Kevin-Mattheus-Moerman I tried hard to figure out DOI's for all the cited papers. Unfortuenately there are no DOI's available for most of them.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Feb 19, 2018

Member

Okay thanks for checking. Did you fix the figure caption?

Member

Kevin-Mattheus-Moerman commented Feb 19, 2018

Okay thanks for checking. Did you fix the figure caption?

@jakobbossek

This comment has been minimized.

Show comment
Hide comment
@jakobbossek

jakobbossek Feb 19, 2018

Yes. Fixed it.

jakobbossek commented Feb 19, 2018

Yes. Fixed it.

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman
Member

Kevin-Mattheus-Moerman commented Feb 19, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Feb 19, 2018

Collaborator
Attempting PDF compilation. Reticulating splines etc...
Collaborator

whedon commented Feb 19, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon
Collaborator

whedon commented Feb 19, 2018

@Kevin-Mattheus-Moerman

This comment has been minimized.

Show comment
Hide comment
@Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman Feb 19, 2018

Member

Looks good. Okay. You know the drill. At this point please share the DOI for the archived version of the reviewed software. Then @arfon can take it from there.

Member

Kevin-Mattheus-Moerman commented Feb 19, 2018

Looks good. Okay. You know the drill. At this point please share the DOI for the archived version of the reviewed software. Then @arfon can take it from there.

@jakobbossek

This comment has been minimized.

Show comment
Hide comment
@jakobbossek

jakobbossek Feb 19, 2018

The DOI is 10.5281/zenodo.1175943
Thanks @Kevin-Mattheus-Moerman and @gvegayon 👏

jakobbossek commented Feb 19, 2018

The DOI is 10.5281/zenodo.1175943
Thanks @Kevin-Mattheus-Moerman and @gvegayon 👏

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Feb 19, 2018

Member

@whedon set 10.5281/zenodo.1175943 as archive

Member

arfon commented Feb 19, 2018

@whedon set 10.5281/zenodo.1175943 as archive

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Feb 19, 2018

Collaborator

OK. 10.5281/zenodo.1175943 is the archive.

Collaborator

whedon commented Feb 19, 2018

OK. 10.5281/zenodo.1175943 is the archive.

@arfon arfon added the accepted label Feb 19, 2018

@arfon

This comment has been minimized.

Show comment
Hide comment
@arfon

arfon Feb 19, 2018

Member

@gvegayon - many thanks for your review here and to @Kevin-Mattheus-Moerman for editing this submission

@jakobbossek - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00528 ⚡️🚀 💥

Member

arfon commented Feb 19, 2018

@gvegayon - many thanks for your review here and to @Kevin-Mattheus-Moerman for editing this submission

@jakobbossek - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00528 ⚡️🚀 💥

@arfon arfon closed this Feb 19, 2018

@whedon

This comment has been minimized.

Show comment
Hide comment
@whedon

whedon Feb 19, 2018

Collaborator

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippet:

[![DOI](http://joss.theoj.org/papers/10.21105/joss.00528/status.svg)](https://doi.org/10.21105/joss.00528)

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Collaborator

whedon commented Feb 19, 2018

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippet:

[![DOI](http://joss.theoj.org/papers/10.21105/joss.00528/status.svg)](https://doi.org/10.21105/joss.00528)

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment