Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: PyDMD: Python Dynamic Mode Decomposition #530
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jkmacc-LANL, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
Conflict of interest
Code of Conduct
referenced this issue
Jan 11, 2018
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
PyDMD is a well-documented, well-tested, easy to install software package. Congratulations! It was a pleasure to review this (...and thanks for your patience). I only had a few minor requests (below). These aren't show-stoppers, so I didn't create issues for them in the project repo. With these minor tweaks, this contribution is easily ready to be accepted.
I installed and ran the tutorial notebooks on OS X 10.12.6 with Python 3.6.4. It went very smoothly.
If you would like to include a link to your paper from your README use the following code snippet:
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: