Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@bovee, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
Review checklist for @bovee
Conflict of interest
Code of Conduct
referenced this issue
Aug 4, 2018
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
This was a pleasure to review. Overall I think this software is a clean, well-implemented mass isotope calculator with good tests, clear API documentation and an easy installation.
I made a few small issues on the repository I'd like to see addressed and I'm not sure if this is valid as an issue on the GitHub repository itself, but expanding the second paragraph in the JOSS paper to explain how
Here are some things you can ask me to do:
Thanks @bovee! I notice there are a few unchecked boxes here still, are they all items that are outstanding in your mind? If so, would you mind linking to the issues you've made on the https://github.com/emptyport/js-emass repository here?
Yes, and sorry, they're all linked to issues I opened:
And I'd also like to see more elaboration on what specific problems the software solves in the paper so the "statement of purpose" is more compelling to someone who's not familiar with the original algorithm and software (but I'm not sure if that's an issue to open on the repo or not).
@emptyport Thanks for those changes! And sorry, but can you explicitly link
would go a long way towards establishing the need for this package specifically (in addition to the text you already have about why existing solutions aren't as easy-to-use).
Other than that, I think this is great and I'm ready to sign off.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: