Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: edarf: Exploratory Data Analysis using Random Forests #92
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Conflict of interest
Paper PDF: 10.21105.joss.00092.pdf
referenced this issue
Oct 12, 2016
Here are some things you can ask me to do:
This is all quite new. Please make sure you check the top of the issue after running a @whedon command (you might also need to refresh the page to see the issue update).
For the most part you need to see if the statements above in the first post are true and check things off accordingly (as you've already started). If something isn't the case, or you otherwise have a suggestion, just post a comment to @zmjones here (or ask me) and we'll sort things out until the submission meets all of JOSS' guidelines.
I have posted in his issue tracker: https://github.com/zmjones/edarf/issues
I do not understand the last point, which also is not a complete sentence:
@PhilippPro - perfect, thank you!
As for the references, I think there's a comma missing, but it otherwise reads fine to me. For each of the references in the compiled paper (https://github.com/openjournals/joss-reviews/files/525302/10.21105.joss.00092.pdf), is there a DOI. Here there are two references, neither of which have a DOI, but I expect both of them should have DOIs, so @zmjones will need to fix that in the bib file. (E.g., older papers may simply not have a DOI to list.)
I added a doi for one article but couldn't find one for the Friedman 2001 article. I do have a jstor stable url that I could include though.
I also added two other papers which use this software, however they are unpublished. Is that ok? I see that it is necessary to talk about applications of the software to solve research problems.
referenced this issue
Oct 14, 2016
It looks like the doi for Friedman (2001) is 10.1214/aos/1013203451 (see http://projecteuclid.org/euclid.aos/1013203451#info). The publisher is also incorrect in being listed as JSTOR.
I think it's fine to cite 'jones2015exploratory' as a conference paper, though I think the booktitle start with "Proceedings of" rather than "Prepared for". If you think there is a stable url, I would appreciate you including it here, but I'll leave that to your discretion.