Join GitHub today
[REVIEW]: graynet: single-subject morphometric networks for neuroscience connectivity applications #924
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@rougier, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
Review checklist for @rougier
Conflict of interest
Code of Conduct
referenced this issue
Sep 2, 2018
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
@raamana I've started the review and I've a few questions:
Thanks for getting started.
cd <<path to cloned graynet>> cd graynet/tests pytest
that will run all tests in
$ 08:38:39 SQuark-3 tests >> pwd /Users/Reddy/dev/graynet/graynet/tests $ 08:38:48 SQuark-3 tests >> pytest ===================================================================================== test session starts ====================================================================================== platform darwin -- Python 3.6.2, pytest-3.4.2, py-1.5.2, pluggy-0.6.0 rootdir: /Users/Reddy/dev/graynet, inifile: plugins: hypothesis-3.30.1 collected 12 items test_graynet.py ............ [100%] ======================================================================================= warnings summary ======================================================================================= graynet/tests/test_graynet.py::test_run_roi_stats_via_API /Users/Reddy/anaconda/envs/py36/lib/python3.6/site-packages/scipy/stats/stats.py:2831: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result. -- Docs: http://doc.pytest.org/en/latest/warnings.html =========================================================================== 12 passed, 1 warnings in 106.92 seconds ============================================================================
trying to fix the docs - exact same config works for many other of my repos: https://raamana.github.io/mrivis/alignment_usage.html
something different for graynet or a bug in Sphinx, need to dig deeper to fix ;)
Users are not expected to run the tests themselves - the badge on the repo
should give them confidence that its passing all the tests, and releases are not made if the tests fail.
Developers/contributors typically know what to do ;)
This document provides details:
Thanks - so the doc website seems to have fixed itself with a new theme: https://raamana.github.io/graynet/index.html
Per your suggestion, I've added the developer guidelines: https://github.com/raamana/graynet/blob/gh-pages/docs/contributing.rst
This will show up on the docs in a few minutes or so
I will add the DOIs now.
PDF failed to compile for issue #924 with the following error:
% Total % Received % Xferd Average Speed Time Time Time Current
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
Hi Ariel, there is some issue with Zenodo - its failing to create a release
Don't want to make a distinct new upload, outside the typical mechanism for Zenodo, that might separate this DOI from the previous releases.. How do you handle this?
I can try again in few days.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: