Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[REVIEW]: compboost: Modular Framework for Component-Wise Boosting #967
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@moonso, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
Review checklist for @moonso
Conflict of interest
Code of Conduct
referenced this issue
Sep 21, 2018
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews
To fix this do the following two things:
For a list of things I can do to help you, just type:
Here are some things you can ask me to do:
Hi @brainstorm ! Thanks for asking me to review, I will do my best here. To start with I have a few questions:
@moonso You can move on into reviewing the other points while the author addresses things. Thanks a lot for helping out JOSS! ;)
Weird, are you sure @schalkdaniel?:
The format you mention seems to belong to
Hi @schalkdaniel @brainstorm . I'm done with the review now, nice job @schalkdaniel
My only remark is the contribution of the co-authors. Thomas Janek has contributed a fairly small part of the code compare to the main author. Also it is unclear how Bernd Bischl have contributed, I guess he is the PI but I think it should be stated somewhere how this person have contributed.
Again good job!
Hi @moonso, thanks for your effort.
Regarding the contribution of the authors: The project has started as master thesis and will probably go on and on. Janek and Bernd give much input on general principles like theory, software design, and many other important things that are not directly visible. Janek also developed main parts of the R API.
I don't know where it is best to mention their contribution. Do you have any preferences?
Ultimately, authorship is left up to the authors but we have some guidelines here: https://joss.readthedocs.io/en/latest/review_criteria.html#authorship
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
Hi @arfon, is it possible to make a small change to the paper? I (stupidly) used a wrong latex symbol and didn't recognize it during the review process. Instead of
It would be really great if I could update the paper with the correct symbol.
Thanks for your efforts!