Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvm to Incubating projects #341

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@brianwarner
Copy link
Contributor

commented Oct 3, 2019

Adding nvm link to list of at-large projects. Welcome, nvm!

Signed-off-by: Brian Warner brian@bdwarner.com

Adding nvm link to list of at-large projects.  Welcome, nvm!

Signed-off-by: Brian Warner <brian@bdwarner.com>
@ljharb
ljharb approved these changes Oct 3, 2019
Copy link
Member

left a comment

<3

@MylesBorins

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

I'm pretty sure this should be under the Incubation umbrella not at-large

My impression is that this is not "officially" in the foundation yet... but that is a bit pedantic. That being said we should likely be careful about that language before IP transfer and acceptance vote has gone through.

Pedantry aside this is exciting! Congrats nvm!

@brianwarner

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

@MylesBorins you are very right, this was my error. My apologies... I should have added an "Incubating" category and welcomed nvm as the first project under that. I'm editing the title of this PR, and will push a new patch in a moment.

@brianwarner brianwarner changed the title Add nvm to at-large projects Add nvm to Incubating projects Oct 3, 2019
This patch adds an Incubating category, and nvm as the first project under it.
This amends the contents of the previous patch, where I erroneously added nvm as
an at-large project.

Signed-off-by: Brian Warner <brian@bdwarner.com>
Copy link
Member

left a comment

LGTM

@eemeli
eemeli approved these changes Oct 4, 2019
Copy link
Member

left a comment

LGTM

@bnb
bnb approved these changes Oct 4, 2019
Copy link
Member

left a comment

🎉

Copy link
Contributor

left a comment

LGTM

@MylesBorins MylesBorins merged commit c54e005 into openjs-foundation:master Oct 8, 2019
MylesBorins added a commit that referenced this pull request Oct 8, 2019
Adding nvm link to list of at-large projects. Welcome, nvm!

Signed-off-by: Brian Warner brian@bdwarner.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.