fix: fix crash when reload page. #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
answershuto
previously approved these changes
Jan 14, 2022
answershuto
approved these changes
Jan 14, 2022
wssgcg1213
reviewed
Jan 17, 2022
| // Should clear previous page cached ui commands | ||
| clearUICommand(_view.contextId); | ||
|
|
||
| // Wait for next microtask to make sure C++ native Elements are GC collected. | ||
| Completer completer = Completer(); | ||
| Future.microtask(() { | ||
| disposePage(_view.contextId); | ||
| _module.dispose(); | ||
| _view.dispose(); |
There was a problem hiding this comment.
之前就是在 microtask 里面销毁 view。后来被 #940 改坏了。导致 reload 无法释放 Bridge 的内存。
wssgcg1213
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1100
https://github.com/openkraken/kraken/pull/1081/files#diff-a21b93f4669388bbfdaff8b8f333f82a26d15b2b7212b990314296c47d1fe93eR111 设置为 nullptr 会导致销毁页面过程中，调用 flushUICommand() 所依赖的 getUICommandItems() 返回为 nullptr， 从而使得 JS 侧 eventTarget 已经被销毁，而 Dart 没有收到指令无法销毁，进行双方不一致导致 crash。