Skip to content
This repository was archived by the owner on May 2, 2019. It is now read-only.

Conversation

@elemoine
Copy link
Member

This PR adds a "serve" command to the "closure-util" binary. This command starts a development server that can be used to serve code using goog.provide and goog.require.

This is how the serve command is used:

closure-util serve config.json

And this is what the JSON config file (config.json) looks like:

{
  "lib": [
    "path/to/my/js/files/**.js"
  ],
  "serve": {
    "port": 3001
  }
}

That configuration file can be the same file as the one used with the build command (with an additional "serve" section).

Requires #52. (now closed)

@elemoine elemoine changed the title (WIP) Add a "serve" command to "closure-util" binary Add a "serve" command to "closure-util" binary Mar 31, 2015
@elemoine
Copy link
Member Author

elemoine commented Apr 2, 2015

Now rebased on the current master.

@elemoine
Copy link
Member Author

elemoine commented Apr 2, 2015

I just updated the description of the issue. Please review.

lib/build.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure you know, but the _privateStyle names are not really necessary. Only properties explicitly assigned to exports or module.exports are available outside this module.

@tschaub
Copy link
Member

tschaub commented Apr 4, 2015

Looks great @elemoine. One minor comment about the _namingConvention, but that is a stylistic thing (and not yet enforced).

Please merge (and release).

@elemoine
Copy link
Member Author

elemoine commented Apr 4, 2015

Looks great @elemoine. One minor comment about the _namingConvention, but that is a stylistic thing (and not yet enforced).

I'll remove the underscore before merging. Thanks for the review.

elemoine pushed a commit that referenced this pull request Apr 4, 2015
Add a "serve" command to "closure-util" binary
@elemoine elemoine merged commit f2ce388 into openlayers:master Apr 4, 2015
@elemoine elemoine deleted the serve-command branch April 4, 2015 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants