Skip to content

Loading…

Remove requires of Format/WKT from Geometry.js #101

Closed
wants to merge 1 commit into from

2 participants

@probins

Can we please remove this requires, so it's no longer included in all vector builds. It is only used by the de/serialize functions, which I would imagine is a minority usage. Would suggest putting a note in the release notes that anyone wanting to use these functions should ensure they have Format/WKT in their build config.

No logic change. Only affects builds.

@tschaub
OpenLayers member

I like the idea of this change, but think it needs to involve a bit more. We don't want to simply fail when someone calls geometry.toString or OpenLayers.Geometry.fromWKT. See #102 for a more complete set of changes.

@probins

There are quite a few inconsistencies in the way that classes use (or not) '@requires', so it wouldn't be alone in 'simply failing'. However, I agree that #102 is much better, so I think we can close this one.

@probins probins closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 10, 2011
  1. @probins

    remove requires of Format/WKT.js

    probins committed
Showing with 2 additions and 1 deletion.
  1. +2 −1 lib/OpenLayers/Geometry.js
View
3 lib/OpenLayers/Geometry.js
@@ -5,8 +5,9 @@
/**
* @requires OpenLayers/BaseTypes/Class.js
- * @requires OpenLayers/Format/WKT.js
* @requires OpenLayers/Feature/Vector.js
+ *
+ * uses OpenLayers/Format/WKT.js
*/
/**
Something went wrong with that request. Please try again.