Fixing XML Validation failure #221

Merged
merged 3 commits into from Feb 15, 2012

Projects

None yet

3 participants

@pgiraud
Member
pgiraud commented Feb 15, 2012

The generated GPX files was not valid according to the schema. This pull request fixes this. Please review.

@elemoine elemoine commented on an outdated diff Feb 15, 2012
lib/OpenLayers/Format/GPX.js
@@ -71,6 +71,13 @@ OpenLayers.Format.GPX = OpenLayers.Class(OpenLayers.Format.XML, {
* "http://www.topografix.com/GPX/1/1 http://www.topografix.com/GPX/1/1/gpx.xsd"
*/
schemaLocation: "http://www.topografix.com/GPX/1/1 http://www.topografix.com/GPX/1/1/gpx.xsd",
+
+ /**
+ * Property: creator
@elemoine
elemoine Feb 15, 2012 Member

This should be an APIProperty I think.

@ahocevar
Member

Very good catch!

@ahocevar
Member

Looks good to me, also with creator not being an API property. Please merge if @elemoine agrees and tests pass.

@elemoine
Member

@ahocevar it makes sense for the application developer to be able to change the creator, that's why I suggested to make it an API option.

@pgiraud pgiraud merged commit cd41548 into openlayers:master Feb 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment