Use dotless identifiers #416

Merged
merged 4 commits into from Apr 23, 2012

Projects

None yet

2 participants

@tschaub
OpenLayers member

Since we use object identifiers as DOM element identifiers throughout the library (control elements, rendered vector nodes) it makes sense to use underscore instead of dots for more sensible CSS selectors.

tschaub added some commits Apr 17, 2012
@tschaub tschaub Toward dotless identifiers. 8533edd
@tschaub tschaub Underscore in canvas hit detection. 163caf0
@tschaub tschaub Using compiled regexp to replace dots.
Though split and join appear to be more efficient in Chrome, a compiled regexp looks to be a safer bet across the board.  See http://jsperf.com/dotless (and http://jsperf.com/dotless-nop for the NOP).
faaa2ce
@tonio
OpenLayers member

Looks good to me. I've already encouter the problem with jQuery.
Should we keep notes of that type of changes for future release notes?

Please merge anyway.

@tschaub tschaub merged commit 2b5b59b into openlayers:master Apr 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment