Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: ol.interaction.Select: layer vs layers options #1991

Closed
fredj opened this issue Apr 17, 2014 · 3 comments · Fixed by #1992
Closed

api: ol.interaction.Select: layer vs layers options #1991

fredj opened this issue Apr 17, 2014 · 3 comments · Fixed by #1992

Comments

@fredj
Copy link
Member

fredj commented Apr 17, 2014

ol.interaction.Select takes a layer and a layers option. If layer is set, layers is ignored.
I propose to remove the layer option.
fredj added a commit to fredj/openlayers that referenced this issue Apr 17, 2014
@fredj
Remove layer option from ol.interaction.Select
4ec313c 
Fixes openlayers#1991
@elemoine
Copy link
Member

Do you also suggest to also remove the layerFilter option?

@fredj
Copy link
Member Author

fredj commented Apr 17, 2014

No because there's no other way to dynamically filter the layers (eg with condition option)

@fredj fredj mentioned this issue Apr 17, 2014
Merged
@tschaub
Copy link
Member

tschaub commented Apr 18, 2014

If the layers option were {Array.<ol.layer.Layer>|function(ol.layer.Layer):boolean} we could have one option and the same functionality.

fredj added a commit to fredj/openlayers that referenced this issue Apr 22, 2014
@fredj
Remove layer option from ol.interaction.Select
6b099c5 
Fixes openlayers#1991
fredj added a commit to fredj/openlayers that referenced this issue Apr 22, 2014
@fredj
Remove layer option from ol.interaction.Select
4dfbfb0 
Fixes openlayers#1991
fredj added a commit to fredj/openlayers that referenced this issue Apr 28, 2014
@fredj
Remove layer option from ol.interaction.Select
0108377 
Fixes openlayers#1991
fredj added a commit to fredj/openlayers that referenced this issue Apr 29, 2014
@fredj
Remove layer option from ol.interaction.Select
2c7282d 
Fixes openlayers#1991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove layer option from ol.interaction.Select fredj/openlayers
3 participants
@tschaub @elemoine @fredj