New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache the buffered extent value #3059
Conversation
8bb2582
to
8c29e46
Compare
be1a9ed
to
ec362e5
Compare
1389941
to
97f2b9e
Compare
Thanks for any review |
// invalid buffered max extent cache | ||
this.bufferedMaxExtent_ = null; | ||
this.maxLineWidth = Math.max(this.maxLineWidth, this.state_.lineWidth); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about not using Math.max
and do this:
if (this.state_.lineWidth > this.maxLineWidth) {
this.maxLineWidth = this.state_.lineWidth;
// invalidate buffered max extent cache
this.bufferedMaxExtent_ = null;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Shouldn't the same be done in the WebGL replay code? |
Assuming that the maxExtent and resolution property are immutable
The WebGL replay code doesn't use a bufferedMaxExtent |
Right. LGTM. |
Thanks for the review |
Assuming that the maxExtent and resolution property are immutable
fixes #3057