Skip to content

Replaced jasmine testing framework by mocha, expect.js and sinon #358

Merged
merged 5 commits into from Mar 13, 2013

4 participants

@Turbo87
Turbo87 commented Mar 13, 2013

.. as discussed in #319

@elemoine elemoine commented on the diff Mar 13, 2013
test/spec/ol/rectangle.test.js
@@ -17,41 +17,55 @@ describe('ol.Rectangle', function() {
beforeEach(function() {
rectangle1 = new ol.Rectangle(50, 50, 100, 100);
- this.addMatchers({
- toIntersects: function(other) {
- return this.actual.intersects(other);
- }
- });
+ expect.Assertion.prototype.intersectWith = function(other) {
+ return this.obj.intersects(other);
+ };
@elemoine
OpenLayers member
elemoine added a note Mar 13, 2013

I think we should do that elsewhere, at a more global level. So this isn't related to the Mocha port, so let's do that with a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@elemoine
OpenLayers member

That is AWESOME! +1 for merging this now.

@ahocevar
OpenLayers member
@twpayne
twpayne commented Mar 13, 2013

This is brilliant, please merge!

@elemoine elemoine merged commit edc1bd5 into openlayers:master Mar 13, 2013

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.