Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation of Image source ratio option. #3947

Merged
merged 1 commit into from Aug 2, 2015

Conversation

alvinlindstam
Copy link
Contributor

Clarifies documentation for the ratio option of ImageWMS, ImageMapGuide, ImageVector and ImageCanvas. Should make it clear that the ratio should be at least 1, and that the ratio is in relation to width/height (not area).

Fixes #3926

@alvinlindstam
Copy link
Contributor Author

All the Image sources with ratios use 1.5 as default, except MapGuideImage which uses 1. Is this intended?

tschaub added a commit that referenced this pull request Aug 2, 2015
Clarify documentation of Image source ratio option.
@tschaub tschaub merged commit 23610ef into openlayers:master Aug 2, 2015
@tschaub
Copy link
Member

tschaub commented Aug 2, 2015

Thanks for the doc improvement @alvinlindstam.

I think 1.5 makes a sensible default ratio. The MapGuide source started out with an unconfigurable ratio of 1. This was later extracted as an option with the same default value. If there is a good reason to change it, it would make a pretty simple pull request.

@alvinlindstam
Copy link
Contributor Author

Ok. 1.5 seems like a reasonable default. I was thinking of changing to 1.5 for MapGuide as well, for consistency but backwards comparability is more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants