Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doc footer with timestamp #3983

Merged
merged 1 commit into from Aug 7, 2015
Merged

Remove doc footer with timestamp #3983

merged 1 commit into from Aug 7, 2015

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented Aug 7, 2015

Including a footer with a timestamp adds a ton of noise to diffs (e.g. openlayers/openlayers.github.io@ff9e7d0). I'd like to make it easier to see significant changes to the website.

@bartvde
Copy link
Member

bartvde commented Aug 7, 2015

👍

@probins
Copy link
Contributor

probins commented Aug 7, 2015

Having the date is useful on master, as there's nothing else to tell you which version of master it refers to.

tschaub added a commit that referenced this pull request Aug 7, 2015
Remove doc footer with timestamp.
@tschaub tschaub merged commit daf85c7 into openlayers:master Aug 7, 2015
@tschaub tschaub deleted the doc-footer branch August 7, 2015 18:59
@tschaub
Copy link
Member Author

tschaub commented Aug 7, 2015

@probins this gives you the same information: https://github.com/openlayers/openlayers.github.io/commits/master/en/master/apidoc/ (timestamp of latest push).

However, it would be nice to make the manual push unnecessary and instead have the website build be triggered by a push to ol3 master.

@probins
Copy link
Contributor

probins commented Aug 8, 2015

that's true; in fact, looking at the commit history is better, as it has the additional advantage that I can search for 'version' to find which commit this is based on if I want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants