Map "view" option may be a View2DOptions #400

Closed
wants to merge 2 commits into from

4 participants

@elemoine
OpenLayers member

Implements what's discussed in #340. To be discussed ; I don't mind throwing this away if people don't like it.

Requires #398.

@twpayne

I like this.

@elemoine
OpenLayers member

Branch updated. Still interested in opinions. Thank you @twpayne for giving yours already.

@tschaub
OpenLayers member

Is the build failure due to a different JSDoc version?

@elemoine
OpenLayers member

I guess so. It looks like every build fails on Travis right now.

@ahocevar
OpenLayers member

JSDoc3 now tries to parse Google Closure type declarations and fails with many types. I'm currently working on making our jsdoc story better, but I'll send a quick pull request that fixes this issue. Hold on, should be there in 5 min.

@ahocevar
OpenLayers member

Travis build fails because of #405. Unfortunately I wasn't able to provide a quick fix.

@twpayne

Can this be merged? The jsdoc3 build problems have been fixed in #415. It's a nice API clean up and problem just needs a little TLC to be merged.

@elemoine
OpenLayers member

I think others probably don't like the typecast in the examples, and I'd understand that.

@elemoine
OpenLayers member

I'm going to rebase my mapviewoption branch onto current master, and merge it, unless I get pushback before I get to it.

@elemoine
OpenLayers member

Now rebased. I don't want to force this in, so please speak up if you don't want it.

@twpayne

+1 from me.

@twpayne

@elemoine, do you still want to merge this? Personally, I like it. The branch needs a little rebase loving to be merged, but is otherwise good.

@elemoine
OpenLayers member

The ol.Map2D discussion makes me hesitant on this one. If we do want ol.Map2D or equivalent this PR probably doesn't make sense anymore.

@twpayne

Thanks @elemoine. Personally, I prefer this PR to the ol.Map2D PR. (The ol.Map2D adds a lot of extra complexity to save the eight characters in view: { ... }.)

@elemoine
OpenLayers member

Stalled issue. No consensus. Closing.

@elemoine elemoine closed this Apr 22, 2013
@elemoine elemoine deleted the elemoine:mapviewoption branch Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment