reconsider default value for anchorYUnits and anchorXUnits in ol.style.Icon #1837

Closed
bartvde opened this Issue Mar 11, 2014 · 4 comments

Comments

Projects
None yet
3 participants
Owner

bartvde commented Mar 11, 2014

Currently the default value is fraction, but IMHO pixels is more commonly used.

bartvde added the api label Mar 11, 2014

Owner

tschaub commented Mar 11, 2014

The benefit of the current defaults is that they should give decent results with a variety of icon sizes.

An alternative would be to parse user provided values and derive the units (as is done with things like 20px and 50% in CSS).

Owner

bartvde commented Mar 12, 2014

good point @tschaub hadn't thought about that

Contributor

twpayne commented Mar 27, 2014

@bartvde, what are your current thoughts on this?

Owner

bartvde commented Mar 27, 2014

I think we close this and leave it as is.

bartvde closed this Mar 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment