New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support editing circles #5510

Closed
tst-ppenev opened this Issue Jun 22, 2016 · 12 comments

Comments

Projects
None yet
6 participants
@tst-ppenev
Contributor

tst-ppenev commented Jun 22, 2016

Hi.

I saw that Open Layers 3 did not come with support for modifying circles in ol.interaction.Modify. I have an implementation of that I can contribute, pending signing a Contributor License Agreement.

Please, let me know if you are accepting a pull-request for this issue.

Thanks,


Pavel

@ahocevar

This comment has been minimized.

Show comment
Hide comment
@ahocevar

ahocevar Jun 23, 2016

Member

Pull request accepted. Thanks.

Member

ahocevar commented Jun 23, 2016

Pull request accepted. Thanks.

@bartvde

This comment has been minimized.

Show comment
Hide comment
@bartvde

bartvde Jul 4, 2016

Member

@tst-ppenev any update on your pull request?

Member

bartvde commented Jul 4, 2016

@tst-ppenev any update on your pull request?

@tst-ppenev

This comment has been minimized.

Show comment
Hide comment
@tst-ppenev

tst-ppenev Jul 4, 2016

Contributor

I'm still waiting for the developer agreement to be signed and transmitted. My fork with the implementation of the feature is at https://github.com/tst-ppenev/ol3.

Contributor

tst-ppenev commented Jul 4, 2016

I'm still waiting for the developer agreement to be signed and transmitted. My fork with the implementation of the feature is at https://github.com/tst-ppenev/ol3.

@jkossis

This comment has been minimized.

Show comment
Hide comment
@jkossis

jkossis Jul 12, 2016

Any news on if this pull request will be accepted? This seems to be a well-desired feature.

jkossis commented Jul 12, 2016

Any news on if this pull request will be accepted? This seems to be a well-desired feature.

@ahocevar

This comment has been minimized.

Show comment
Hide comment
@ahocevar

ahocevar Jul 12, 2016

Member

@jkossis The pull request will be accepted, but @tst-ppenev is waiting for their organisation to submit the contributor's license agreement.

Member

ahocevar commented Jul 12, 2016

@jkossis The pull request will be accepted, but @tst-ppenev is waiting for their organisation to submit the contributor's license agreement.

@rxnh8255

This comment has been minimized.

Show comment
Hide comment
@rxnh8255

rxnh8255 Sep 7, 2016

@tst-ppenev Can I modify circles Now?please show me some code,thanks

rxnh8255 commented Sep 7, 2016

@tst-ppenev Can I modify circles Now?please show me some code,thanks

@tst-ppenev

This comment has been minimized.

Show comment
Hide comment
@tst-ppenev

tst-ppenev Sep 7, 2016

Contributor

@rxnh8255,

Well, this is a new feature accessed through mouse interaction. There isn't any code you need to add in order to use it, just create some circles and add them to the collection of modifiable objects.

The pull request (#5704) has not been merged, yet, so you'll have to do that yourself before building OpenLayers, or use my fork (which doesn't include other latest merges).

Here's a screencast of <examples/draw-and-modify-features.html> from my fork.

Draw-and-modify-circles.webm.zip

Unfortunately, GitHub doesn't allow direct upload of <.webm>, so it's zipped.

Contributor

tst-ppenev commented Sep 7, 2016

@rxnh8255,

Well, this is a new feature accessed through mouse interaction. There isn't any code you need to add in order to use it, just create some circles and add them to the collection of modifiable objects.

The pull request (#5704) has not been merged, yet, so you'll have to do that yourself before building OpenLayers, or use my fork (which doesn't include other latest merges).

Here's a screencast of <examples/draw-and-modify-features.html> from my fork.

Draw-and-modify-circles.webm.zip

Unfortunately, GitHub doesn't allow direct upload of <.webm>, so it's zipped.

@tst-ppenev

This comment has been minimized.

Show comment
Hide comment
@tst-ppenev

tst-ppenev Sep 7, 2016

Contributor

Oh, and I did hear that licenses are cleared from my organization before I opened the pull request.

Contributor

tst-ppenev commented Sep 7, 2016

Oh, and I did hear that licenses are cleared from my organization before I opened the pull request.

@rxnh8255

This comment has been minimized.

Show comment
Hide comment
@rxnh8255

rxnh8255 Sep 7, 2016

thanks,can u send me a debug version of the ol.js,I could not build from your fork

rxnh8255 commented Sep 7, 2016

thanks,can u send me a debug version of the ol.js,I could not build from your fork

@tst-ppenev

This comment has been minimized.

Show comment
Hide comment
@tst-ppenev

tst-ppenev Sep 7, 2016

Contributor

@rxnh8255,

I presume you need this:
ol-debug.js.zip

Contributor

tst-ppenev commented Sep 7, 2016

@rxnh8255,

I presume you need this:
ol-debug.js.zip

@rxnh8255

This comment has been minimized.

Show comment
Hide comment
@rxnh8255

rxnh8255 Sep 8, 2016

Yes,I need this
Thank you veeeeeeeeeeeeeeeeeeery much!!!

rxnh8255 commented Sep 8, 2016

Yes,I need this
Thank you veeeeeeeeeeeeeeeeeeery much!!!

@fredj

This comment has been minimized.

Show comment
Hide comment
@fredj

fredj May 9, 2017

Member

fixed with #6457

Member

fredj commented May 9, 2017

fixed with #6457

@fredj fredj closed this May 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment